Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from prebid:master #1618

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 14, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

mp4symitri and others added 19 commits September 9, 2024 12:35
* OnBidResponse listener added to add pixel for deals matching to the user deals stored in local storage

* Adding support for simpleId, compositeId & hashedId

* Solved Linter errors. Made some changes to reduce integration errors

* Rolled back the default case as it was generating test errors.

* Testing onBidResponseEvent

* Pass pixel URL as module config parameter

* Added extra attributes to Pixel URL.
Documentation Updated.

* Bidder Name & Code both added

* Fixed Tests
Fixed Linter Errors
Updated Example

---------

Co-authored-by: Manan <[email protected]>
Co-authored-by: Jeff Palladino <[email protected]>
* Yandex Id System: add ext for eids

* add check cookiesAreEnabled

* add tests
* Add ability to override site from a global object

* Add test for overrides

---------

Co-authored-by: daniel manan <[email protected]>
* implement viewability support

openxBidAdapter remove PAF, bugfix  ortbConverter response (#12105)

Appnexus Bid Adapter: fix parse of the encoded string to check for ast_override_div argument (#12106)

Richaudience Bid Adapter : add compability with DSA (#12099)

* Update richaudienceBidAdapter.md

Update maintainer e-mail to [email protected]

* Add richaudienceBidAdapter.js file

* Add richaudienceBidAdapter_spec.js

* Update richaudienceBidAdapter.js

* RichaudienceBidAdapter add compability with DSA

* RichaudienceBidAdapter add compability with DSA

* RichaudienceBidAdapter add compability with DSA

---------

Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: sergigimenez <[email protected]>

finish unit testing

added container identifier for viewability on bid params

Add new TGM adapter (#12100)

Co-authored-by: apykhteyev <[email protected]>

Prebid 9.9.0 release

Increment version to 9.10.0-pre

deprecate old copper6 alias (#12112)

LimelightDigital Adapter: Add support of ortb2 and ortb2Imp objects (#12078)

* Add support of ortb2 and ortb2Imp objects

* Fix tests

* Fix tests

---------

Co-authored-by: apykhteyev <[email protected]>

update configuration example (#12109)

FPD Enrichment: Replace device values `w` and `h` with screen size; add `ext.vpw` and `ext.vph` (#12108)

Core: fix broken native resizing (#12096)

* Core: fix broken native resizing

* fix test

Weborama RTD Module: BUGFIX on user-centric profile validation (#12095)

* update unit tests

* fix code and doc

* improve integration example

* add extra test

* improve logging

* fix lint issues

hotfix - after this I will fix all tests

fix

fix width and height

fix iframe detection

change detected viewability between 0 and 1 to be consistent with declared viewability

improve the case case where the publisher doesn't send us a container id to check viewability

fully covered by tests

fix test that works local

re-use percentInView method

fix unit tests

removed test

Revert "removed test"

This reverts commit 15dcab7.

Anyclip Bid Adapter : refactor bid adapter (#12030)

* update anyclip adapter

* remove coppa

* fix jsdoc warnings

* create bidderUtils

* delete duplicate code

* refactor

---------

Co-authored-by: Chucky-choo <[email protected]>

Digital Matter Bid Adapter: initial release (#12114)

* update anyclip adapter

* remove coppa

* fix jsdoc warnings

* create bidderUtils

* delete duplicate code

* refactor

* add digitalMatter Bid Adapter

---------

Co-authored-by: Chucky-choo <[email protected]>

IX Bid Adapter: Remove client FT pbjs_allow_all_eids (#12117)

Co-authored-by: Sajid Mahmood <[email protected]>

SeedingAlliance Adapter: rework to properly use openRTB standard internally (#12101)

* rework adapter to only use openRTB data internally

* added comments

* fix lint errors

saambaaBidAdapter.js:  make alias of advangelist (#11992)

* saambaaBidAdapter.js: reuse repeated code block

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Create index.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Delete modules/saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update beachfrontBidAdapter.js

* Update beachfrontBidAdapter.js

* Update beachfrontBidAdapter.js

* Update nextrollBidAdapter.js

* Update beachfrontBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update beachfrontBidAdapter.js

* Create saambaaBidAdapter.js

* fix file name

---------

Co-authored-by: Chris Huie <[email protected]>

Prebid 9.10.0 release

Increment version to 9.11.0-pre

Core: make sure adUnitCodes are unique in auction events (#12127)

Mobian RTD provider: update API endpoint (#12121)

* update API endpoint for mobian RTD provider

* lint mobian RTD provider

Initial Commit for Symitri Analytics Adapter (#12132)

Co-authored-by: Manan <[email protected]>

Djax Bid Adapter : initial release (#12120)

* Djax bid adapter files added

* fix linting issue

* Linting issue fixed

* Update djaxBidAdapter.js

* Update djaxBidAdapter_spec.js

* Update djaxBidAdapter_spec.js

---------

Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>

Preciso : Added new library to remove code duplication in bid adapter (#11868)

* Preciso : Added new library to remove code duplication in bid adapter

* modified bidfloor mapping logic

* error fix

* error fix

* import bidUtils.js in IdxBidadapter to reduce the code duplicataion

* import bidUtils.js in IdxBidadapter to reduce the code duplicataion

* Error fix

* Imported bidUtils library into redtram bid adapter

* import common library in mediabramaBidAdapter

* import common library in loganBidAdapter to remove code duplication

* removed storageManaser from library

* renderer.js changes reverted

33across - allow aliasing (#12138)

Updating isBidRequestValid logic to account for aliasing of bidder names (#12136)

Digitalmatter Bid Adapter : add dichange alias (#12133)

* add alias

* fix alias

---------

Co-authored-by: Chucky-choo <[email protected]>

add media consortium adapter (#11892)

Co-authored-by: Maxime Lequain <[email protected]>

UserID: merge EIDs with first party data (#12110)

* ortbConverter: do not override EIDS provided as first party data

* update tests

* Allow bidder-specific FPD enrichments

* Refactor eid generation, add primaryIds

* EIDs as FPD

* Fix tests

* PBS tests, fix multiple hook registration

* Fix more test cleanup

* remove eidPermissions

* refactor oderByPriority

* refactor initializedSubmodules

* fix lint

* update id5 primaryIds

* simplify eid source filtering

* clean up PBS userId logic

* Revert "Allow bidder-specific FPD enrichments"

This reverts commit 2fb7452.

* undo bidder-specific enrichments

* use startAuction instead of requestBids

* add test on userIdAsEids

* Fix lint

Bump ws, @wdio/browserstack-service, @wdio/cli and @wdio/local-runner (#12148)

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@wdio/browserstack-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-browserstack-service), [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) and [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner). These dependencies need to be updated together.

Updates `ws` from 8.13.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.13.0...8.17.1)

Updates `@wdio/browserstack-service` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-browserstack-service)

Updates `@wdio/cli` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-cli)

Updates `@wdio/local-runner` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-local-runner)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: "@wdio/browserstack-service"
  dependency-type: direct:development
- dependency-name: "@wdio/cli"
  dependency-type: direct:development
- dependency-name: "@wdio/local-runner"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Smartadserver Bid Adapter : add DSA support (#12141)

* add support of dsa

* restore topics

* DSA fix for UT

Change consent default param name (#12154)

Co-authored-by: Danijel Ristic <[email protected]>

Freedom Ad Network Bid Adapter: initial release (#12153)

* Create fanAdapter.md

* Create fanAdapter.js

* Create fanAdapter_spec.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter.js

deleted bidder name check (#12157)

Co-authored-by: Octavia Suceava <[email protected]>

Connatix Bid Adapter : support eids (#12142)

* add eids on request

* change naming

---------

Co-authored-by: Darian Avasan <[email protected]>
Co-authored-by: Octavia Suceava <[email protected]>

PrebidServer Bid Adapter : update to use gloablly defined alias or s2sConfig defined alias (#12159)

* update to use gloablly defined alias or s2sConfig defined alias

* Add test case

---------

Co-authored-by: Demetrio Girardi <[email protected]>

* fix build

* test if can fix

* Revert "test if can fix"

This reverts commit 221f612.

* remove test

* refactoring

---------

Co-authored-by: Demetrio Girardi <[email protected]>
* new adapter - MgidX

* add new required param host

* rem host, add region

* MGIDX Adapter: update

* add gpid to imp ext

* fix eu domain

---------

Co-authored-by: Evgeny Nagorny <[email protected]>
Co-authored-by: xmgiddev <>
Co-authored-by: gaudeamus <[email protected]>
* Added AdGrid Adapter Files

* Removed coppa
* Updated docereeAdManager bid adapter

* Updated docereeAdManager bid adapter

* Updated docereeAdManager bid adapter

* Updated docereeAdManager bid adapter

* Updated docereeAdManager bid adapter

* Updated docereeAdManager bid adapter

* Update docereeAdManagerBidAdapter.js

* added test cases for payload formation in DocereeAdManager

* Added support for publisherUrl

* added some parameters

* Added support for TCF 2.2

---------

Co-authored-by: lokesh-doceree <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Bumps [dset](https://github.com/lukeed/dset) from 3.1.2 to 3.1.4.
- [Release notes](https://github.com/lukeed/dset/releases)
- [Commits](lukeed/dset@v3.1.2...v3.1.4)

---
updated-dependencies:
- dependency-name: dset
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updating bid adapter and unit tests to remove some default video logic, which will now be handled within the Sharethrough exchange.
Co-authored-by: Murano Takamasa <[email protected]>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@pull pull bot added the ⤵️ pull label Sep 14, 2024
## Type of change
- [x] Updated bidder adapter

## Description of change
This adds handling for a parameter that is only used internally when the adapter is used on dailymotion.com
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

…, and etc. (#12242)

* Update tests for sspBC adapter

Update tests for sspBC adapter:
- change userSync test (due to tcf param appended in v4.6)
- add tests for onBidWon and onTimeout

* [sspbc-adapter] 5.3 updates: content-type for notifications

* [sspbc-adapter] pass CTA to native bid

* [sspbc-5.3] keep pbsize for detected adunits

* [maintenance] - remove old test for sspBc bid adaptor

* [sspbc-5.3] increment adaptor ver

* [sspbc-adapter] maintenance update to sspBCBidAdapter

* remove yarn.lock

* Delete package-lock.json

* remove package-lock.jsonfrom pull request

* [sspbc-adapter] send pageViewId in request

* [sspbc-adapter] update pageViewId test

* [sspbc-adapter] add viewabiility tracker to native ads

* [sspbc-adapter] add support for bid.admNative property

* [sspbc-adapter] ensure that placement id length is always 3 (improves matching response to request)

* [sspbc-adapter] read publisher id and custom ad label, then send them to banner creative

* [sspbc-adapter] adlabel and pubid are set as empty strings, if not present in bid response

* [sspbc-adapter] jstracker data fix

* [sspbc-adapter] jstracker data fix

* [sspbc-adapter] send tagid in notifications

* [sspbc-adapter] add gvlid to spec; prepare getUserSyncs for iframe + image sync

* update remote repo

* cleanup of grupawp/prebid master branch

* update sspBC adapter to v 5.9

* update tests for sspBC bid adapter

* [sspbc-adapter] add support for topicsFPD module

* [sspbc-adapter] change topic segment ids to int

* sspbc-5.94: read bid platform

* sspbc-5.94 wip

* [sspbc-adapter] major version 6.00 (uses backend renderer)

* [sspbc-adapter] 6.0 add support for PAAPI component auctions

* [sspbc-adapter] default platform value for non-bid notifications

* [sspbc-6.0] add default value for native title length

* [sspbc-6.0] include interstitial info in request

* [sspbc-adapter] update to v6, test coverage and smaller fixes

* remove lint console override

---------

Co-authored-by: Wojciech Biały <[email protected]>
Co-authored-by: decemberWP <[email protected]>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

## Type of change
- [x] Updated bidder adapter

## Description of change
This fixes a naming issue and correctly reports categories from the main ORTB2 site or app objects along with the one coming from the content object.
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

* New Bidder: dexerto

* added page property in site object.

* made requested changes

* handled response when no bid.
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

…12167)

* CM-1260 Implement LiveIntent Prebid User Id Module Based On The Hub

* add tests and rebase to the correct master

* add fpid handling

* fix naming

* Revert superfluous changes

* Update test/spec/modules/liveIntentIdHubSystem_spec.js

Co-authored-by: Viktor Dreiling <[email protected]>

* Fix eids generation

* comment

* only keep collect and rename

* wrong name

* rename and fix import

* Clean up after merge

* Lint

* Lint more

* Put back module loading

* fix import

---------

Co-authored-by: Peixun Zhang <[email protected]>
Co-authored-by: PeiZ <[email protected]>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

Co-authored-by: Komal Kumari <[email protected]>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

#12273)

* refactor to targeting file for readability and efficiency

js doc

fix

* fix

update

update

fix again

---------

Co-authored-by: Michael Moschovas <[email protected]>
Copy link

github-actions bot commented Oct 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 1, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

Copy link

github-actions bot commented Oct 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 1, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

Copy link

github-actions bot commented Oct 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 1, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

Copy link

github-actions bot commented Oct 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 2, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

* Add new video module for AdPlayer.Pro

* Fix offEvent function with callback
Copy link

github-actions bot commented Oct 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 2, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

* Digital Matter Bid Adapter: Refactor Adapter

* Digital Matter Bid Adapter: add aliases

* Digital Matter Bid Adapter: add gvlid
Copy link

github-actions bot commented Oct 3, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Oct 3, 2024

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentIdSystem.js (+3 errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.