Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codepage 1047 for EBCDIC #226

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Add codepage 1047 for EBCDIC #226

merged 1 commit into from
Sep 8, 2024

Conversation

v1gnesh
Copy link
Contributor

@v1gnesh v1gnesh commented Aug 4, 2024

Thanks for yet another excellent tool.

EDIT: How much would work is it to make the bytes show up bolder, like with xxd?

@sharkdp
Copy link
Owner

sharkdp commented Sep 6, 2024

Thank you for your contribution. What is the advantage of that code page over the existing formats?

How much would is it to make the bytes show up bolder, like with xxd?

what exactly do you mean?

@v1gnesh
Copy link
Contributor Author

v1gnesh commented Sep 7, 2024

What is the advantage of that code page over the existing formats?

What existing formats do you mean?
The advantage is that I can now see EBCDIC strings with hexyl, as is possible with xxd.
If you mean why this particular EBCDIC character set (when there are many EBCDIC character sets), this (1047) is the default on a widely used (but not known) platform that uses EBCDIC (mainframe).

Updated the first comment; I meant 'work' instead of 'would'.

alias xxd='xxd -d -E -o 1 -g 1'

with xxd (see that it's bold)

image

alias hxl='$HOME/_dev/hexyl/target/release/hexyl --character-table=codepage-1047 --panels 4'

with this patch in hexyl

image

@sharkdp
Copy link
Owner

sharkdp commented Sep 8, 2024

What existing formats do you mean?
The advantage is that I can now see EBCDIC strings with hexyl, as is possible with xxd.

Ah, I didn't notice that the alphanumeric block somewhere else compared to the ASCII encoding. Thanks.

with xxd (see that it's bold)

Ah. You seem to have a different version of xxd. For me, it's not bold. I don't think it would be a lot of work. Can we please open a new ticket for this?

@sharkdp sharkdp merged commit 427a552 into sharkdp:master Sep 8, 2024
14 checks passed
@v1gnesh
Copy link
Contributor Author

v1gnesh commented Oct 18, 2024

@sharkdp Congrats on you joining Astral. Very, very satisfying that meticulous & hard work is matched with worthy reward & recognition 💪

Would you mind publishing a release, please, with this addition in?

@sharkdp
Copy link
Owner

sharkdp commented Oct 29, 2024

@sharkdp Congrats on you joining Astral. Very, very satisfying that meticulous & hard work is matched with worthy reward & recognition 💪

Thank you!

Would you mind publishing a release, please, with this addition in?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants