Skip to content

Commit

Permalink
Merge pull request #18 from sheinbergon/osx-support
Browse files Browse the repository at this point in the history
OSX support
  • Loading branch information
sheinbergon authored Oct 6, 2020
2 parents 3c3c884 + 3e1011c commit c29c17f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/multi-platform-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-20.04, windows-2019 ]
os: [ ubuntu-20.04, windows-2019, macos-10.15 ]
env:
OS: ${{ matrix.os }}
steps:
Expand Down
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,22 @@ Artifacts are available on maven central:
<dependency>
<groupId>org.sheinbergon</groupId>
<artifactId>jna-aac-encoder</artifactId>
<version>0.1.5</version>
<version>0.1.6</version>
</dependency>
```

**_Gradle_**
```groovy
compile 'org.sheinbergon:jna-aac-encoder:0.1.5'
compile 'org.sheinbergon:jna-aac-encoder:0.1.6'
```

#### Additional information
* Unlike previous releases, there's now a single artifact containing _libfdk-aac_ shared libraries cross-compiled for
both linux and windows (32-bit and 64-bit)
* Single artifact containing _libfdk-aac_ shared libraries cross-compiled for:
* Linux (64-bit)
* Windows (32-bit and 64-bit)
* OSX (64-bit, compiled with Xcode 9.4.1 SDK)
* Provided fdk-aac version is 0.1.6
* Both versions 0.1.5 and 0.1.6 were tested and found to comply with this bridge.
* Both versions 0.1.6 and 0.1.6 were tested and found to comply with this bridge.

### Encoding using the JVM AudioSystem
```java
Expand Down Expand Up @@ -83,7 +85,6 @@ Additional restrictions:

## Roadmap
* Upgrade to fdk-aac 2.0.x
* Re-add macos shared library to the build.
* Improved lower-level interface (with examples).
* Support for 24 bit WAV input (via conversion).
* M4A encoding.
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ ext {
ext.nexus.url = nexus.target.equals('SNAPSHOT') ? ossSnapshotsRepositoryUrl : ossReleasesRepositoryUrl

group 'org.sheinbergon'
version '0.1.5'
version '0.1.6'

sourceCompatibility = 11

Expand Down
Binary file added src/main/resources/darwin/libfdk-aac.dylib
Binary file not shown.

0 comments on commit c29c17f

Please sign in to comment.