[AMORO-1242] Fix refreshing a large number of tables during optimizin…

…g plan (apache#1928) * checking pending before refresh table * add log for plan cost if table is pending
shendanfengg · Sep 7, 2023 · f721b9a · f721b9a
1 parent b9257c1
commit f721b9a
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/...server/src/main/java/com/netease/arctic/ams/server/service/impl/OptimizeQueueService.java b/...server/src/main/java/com/netease/arctic/ams/server/service/impl/OptimizeQueueService.java
@@ -731,6 +731,10 @@ private List<OptimizeTaskItem> plan(long currentTime) {
       for (TableIdentifier tableIdentifier : tableSort) {
         try {
           TableOptimizeItem tableItem = ServiceContainer.getOptimizeService().getTableOptimizeItem(tableIdentifier);
+          if (tableItem.getTableOptimizeRuntime().getOptimizeStatus() != TableOptimizeRuntime.OptimizeStatus.Pending) {
+            // only table in pending should plan
+            continue;
+          }
           ArcticTable arcticTable = tableItem.getArcticTable(true);
 
           Map<String, String> properties = arcticTable.properties();
@@ -764,12 +768,8 @@ private List<OptimizeTaskItem> plan(long currentTime) {
             }
           }
 
-          if (tableItem.getTableOptimizeRuntime().getOptimizeStatus() != TableOptimizeRuntime.OptimizeStatus.Pending) {
-            // only table in pending should plan
-            continue;
-          }
-
           OptimizePlanResult optimizePlanResult = OptimizePlanResult.EMPTY;
+          long startPlanTime = System.currentTimeMillis();
           if (tableItem.startPlanIfNot()) {
             try {
               if (TableTypeUtil.isIcebergTableFormat(arcticTable)) {
@@ -779,13 +779,13 @@ private List<OptimizeTaskItem> plan(long currentTime) {
               }
             } finally {
               tableItem.finishPlan();
+              LOG.info("{} finish plan cost {} ms, get {} tasks", tableItem.getTableIdentifier(),
+                  System.currentTimeMillis() - startPlanTime, optimizePlanResult.getOptimizeTasks().size());
             }
           }
 
           if (!optimizePlanResult.isEmpty()) {
             initTableOptimizeRuntime(tableItem, optimizePlanResult);
-            LOG.debug("{} after plan get {} tasks", tableItem.getTableIdentifier(),
-                optimizePlanResult.getOptimizeTasks().size());
 
             List<OptimizeTaskItem> toExecuteTasks = addTask(tableItem, optimizePlanResult.getOptimizeTasks());
             if (!toExecuteTasks.isEmpty()) {