test(gh-action): add node16 in test matrix

shiftcode · Feb 21, 2023 · 2ec7c3f · 2ec7c3f
1 parent e2bcb11
commit 2ec7c3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -17,8 +17,9 @@ jobs:
   test:
     strategy:
       matrix:
-        # Test with Node.js v18 (LTS) and v19 current
+        # Test with Node.js v16 (maintenance), v18 (LTS) and v19 current
         node:
+          - 16
           - 18
           - 19
     name: Node.js v${{ matrix.node }}
@@ -50,6 +51,7 @@ jobs:
       # Run tests
       - run: npm run test:ci
   build:
+    needs: test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/v2-v3-migration.md b/v2-v3-migration.md
@@ -11,10 +11,10 @@
 
 ## Todo
 Search for `TODO v3:` to see open issues / notes, here are some more general ones:
-- [ ] Make sure the snippets compile
+- [x] Make sure the snippets compile
 - [ ] Check on new attribute type [$UnknownAttribute](./src/mapper/type/attribute.type.ts) and implement tests
-- [ ] Add new demo with aws-cdk
-- [ ] Make tests compile and run successfully
+- [ ] Add new [demo](https://github.com/shiftcode/dynamo-easy-demo) with aws-cdk
+- [x] Make tests compile and run successfully
 - [ ] Remove [sessionValidityEnsurer](./src/config/dynamo-easy-config.ts) and add demo with using [middleware stack](https://github.com/aws/aws-sdk-js-v3#middleware-stack) 
 to implement the same
 - [ ] Switch to new implementation of pagination, see [official doc](https://github.com/aws/aws-sdk-js-v3#paginators).