-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @angular-eslint/* #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message is a bit misleading, since this change has not directly todo with angular@19 but instead with @angular-eslint/* packages, which then use angular@19 under the hood, but let's keep it like that
@michaelwittwer I based my commit message on your analog
"@angular-eslint/eslint-plugin-template": "^18.0.0", | ||
"@angular-eslint/schematics": "^18.0.0", | ||
"@angular-eslint/template-parser": "^18.0.0" | ||
"@angular-eslint/builder": "^19.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is no explicit reason on why 19.0.0
& 19.0.1
are not allowed, I would just use ^19.0.0
as peerDep definition.
@@ -37,19 +37,19 @@ | |||
}, | |||
"dependencies": { | |||
"@shiftcode/eslint-plugin-rules": "^2.0.1", | |||
"@typescript-eslint/eslint-plugin": "^7.16.0", | |||
"@typescript-eslint/parser": "^7.16.0", | |||
"@typescript-eslint/eslint-plugin": "^8.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the latest versions here and next line
@vitaliibendyk did you check the CHANGELOG and Announcing Typescript EsLint 8 to make sure there are no additional changes necessary? |
@vitaliibendyk every new version of |
@vitaliibendyk please also update the |
Thanks for pointing it out. In the end it's true, but not the full story. 🙈 As i said, leave it like that. |
You are right. I meant |
a824829
to
529fd43
Compare
BREAKING CHANGE:
Requires angular 19.