Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @angular-eslint/* #35

Closed
wants to merge 0 commits into from
Closed

Conversation

vitaliibendyk
Copy link
Collaborator

BREAKING CHANGE:
Requires angular 19.

Copy link
Member

@michaelwittwer michaelwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is a bit misleading, since this change has not directly todo with angular@19 but instead with @angular-eslint/* packages, which then use angular@19 under the hood, but let's keep it like that
@michaelwittwer I based my commit message on your analog

Screenshot 2024-12-11 at 11 37 05

"@angular-eslint/eslint-plugin-template": "^18.0.0",
"@angular-eslint/schematics": "^18.0.0",
"@angular-eslint/template-parser": "^18.0.0"
"@angular-eslint/builder": "^19.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no explicit reason on why 19.0.0 & 19.0.1 are not allowed, I would just use ^19.0.0 as peerDep definition.

@@ -37,19 +37,19 @@
},
"dependencies": {
"@shiftcode/eslint-plugin-rules": "^2.0.1",
"@typescript-eslint/eslint-plugin": "^7.16.0",
"@typescript-eslint/parser": "^7.16.0",
"@typescript-eslint/eslint-plugin": "^8.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the latest versions here and next line

@michaelwittwer
Copy link
Member

@vitaliibendyk did you check the CHANGELOG and Announcing Typescript EsLint 8 to make sure there are no additional changes necessary?

@michaelwittwer
Copy link
Member

@vitaliibendyk every new version of @angular-eslint brings changes to which rules are enabled, make sure to test this version in an existing project to know if we need to update our rules configuration.

@michaelwittwer
Copy link
Member

michaelwittwer commented Dec 11, 2024

@vitaliibendyk please also update the @angular-esling/* packages in our eslint-plugin-rules package.
@michaelwittwer We don't have that
Screenshot 2024-12-11 at 11 44 04

@michaelwittwer michaelwittwer linked an issue Dec 11, 2024 that may be closed by this pull request
@michaelwittwer
Copy link
Member

The commit message is a bit misleading, since this change has not directly todo with angular@19 but instead with @angular-eslint/* packages, which then use angular@19 under the hood, but let's keep it like that @michaelwittwer I based my commit message on your analog Screenshot 2024-12-11 at 11 37 05

Thanks for pointing it out. In the end it's true, but not the full story. 🙈 As i said, leave it like that.

@michaelwittwer
Copy link
Member

@vitaliibendyk please also update the @angular-esling/* packages in our eslint-plugin-rules package. @michaelwittwer We don't have that Screenshot 2024-12-11 at 11 44 04

You are right. I meant @typescript-eslint/*, since this is probably also a BREAKING CHANGE but only upgrade if it still works with eslint@8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants