後方互換性を維持するために OnSwitched を空の関数にする & CHANGES.md を修正する

shiguredo · Feb 19, 2024 · c02cce7 · c02cce7
1 parent c06a747
commit c02cce7
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 5 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -26,7 +26,7 @@
   - force_i420_conversion_for_simulcast_adapter のデフォルト値は true で I420 への変換を行う
   - 変換を行わない場合、エンコードの性能が向上するが、バッファーの実装によってはサイマルキャストが利用できなくなる
   - @enm10k
-- [UPDATE] SoraSignalingObserver に OnSwitched を追加する
+- [ADD] SoraSignalingObserver に OnSwitched を追加する
   - @enm10k
 - [FIX] Jetson Orin で AV1 を送信中、他のユーザーが後から接続して受信した時に映像が出ない問題を修正
   - @melpon

diff --git a/include/sora/sora_signaling.h b/include/sora/sora_signaling.h
@@ -48,7 +48,7 @@ class SoraSignalingObserver {
   virtual void OnNotify(std::string text) = 0;
   virtual void OnPush(std::string text) = 0;
   virtual void OnMessage(std::string label, std::string data) = 0;
-  virtual void OnSwitched(std::string text) = 0;
+  virtual void OnSwitched(std::string text){};
 
   virtual void OnTrack(
       rtc::scoped_refptr<webrtc::RtpTransceiverInterface> transceiver) = 0;

diff --git a/test/connect_disconnect.cpp b/test/connect_disconnect.cpp
@@ -103,7 +103,6 @@ class SoraClient : public std::enable_shared_from_this<SoraClient>,
   void OnNotify(std::string text) override {}
   void OnPush(std::string text) override {}
   void OnMessage(std::string label, std::string data) override {}
-  void OnSwitched(std::string text) override {}
 
   void OnTrack(rtc::scoped_refptr<webrtc::RtpTransceiverInterface> transceiver)
       override {}

diff --git a/test/datachannel.cpp b/test/datachannel.cpp
@@ -100,7 +100,6 @@ class SoraClient : public std::enable_shared_from_this<SoraClient>,
   void OnNotify(std::string text) override {}
   void OnPush(std::string text) override {}
   void OnMessage(std::string label, std::string data) override {}
-  void OnSwitched(std::string data) override {}
 
   void OnTrack(rtc::scoped_refptr<webrtc::RtpTransceiverInterface> transceiver)
       override {}

diff --git a/test/lyra.cpp b/test/lyra.cpp
@@ -86,7 +86,6 @@ class SoraClient : public std::enable_shared_from_this<SoraClient>,
   void OnNotify(std::string text) override {}
   void OnPush(std::string text) override {}
   void OnMessage(std::string label, std::string data) override {}
-  void OnSwitched(std::string data) override {}
 
   void OnTrack(rtc::scoped_refptr<webrtc::RtpTransceiverInterface> transceiver)
       override {}