SoraSignalingObserver に OnSwitched を追加する #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melpon
reviewed
Feb 19, 2024
include/sora/sora_signaling.h
Outdated
| @@ -48,6 +48,7 @@ class SoraSignalingObserver { | |||
| virtual void OnNotify(std::string text) = 0; | |||
| virtual void OnPush(std::string text) = 0; | |||
| virtual void OnMessage(std::string label, std::string data) = 0; | |||
| virtual void OnSwitched(std::string text) = 0; | |||
There was a problem hiding this comment.
これだと既存のコードが破壊的変更になるので、空実装を入れておいてください
There was a problem hiding this comment.
空の関数に差し替えました
また、修正前は OnSwitched を hello に実装していましたが、 datachannel に変えました
(元から data_channel_signaling = true が設定されており、動作を確認しやすいためです)
CHANGES.md
Outdated
| @@ -26,6 +26,8 @@ | |||
| - force_i420_conversion_for_simulcast_adapter のデフォルト値は true で I420 への変換を行う | |||
| - 変換を行わない場合、エンコードの性能が向上するが、バッファーの実装によってはサイマルキャストが利用できなくなる | |||
| - @enm10k | |||
| - [UPDATE] SoraSignalingObserver に OnSwitched を追加する | |||
enm10k
commented
Feb 19, 2024
| @@ -66,7 +66,7 @@ class SoraClient : public std::enable_shared_from_this<SoraClient>, | |||
| [this](const boost::system::error_code&, int) { conn_->Disconnect(); }); | |||
|
|
|||
| timer_.reset(new boost::asio::deadline_timer(*ioc_)); | |||
| timer_->expires_from_now(boost::posix_time::seconds(1)); | |||
| timer_->expires_from_now(boost::posix_time::seconds(3)); | |||
There was a problem hiding this comment.
@melpon 私が利用した環境では動作が安定しなかったため、秒数を伸ばしました
melpon
reviewed
Feb 19, 2024
include/sora/sora_signaling.h
Outdated
| @@ -48,6 +48,7 @@ class SoraSignalingObserver { | |||
| virtual void OnNotify(std::string text) = 0; | |||
| virtual void OnPush(std::string text) = 0; | |||
| virtual void OnMessage(std::string label, std::string data) = 0; | |||
| virtual void OnSwitched(std::string text){}; | |||
There was a problem hiding this comment.
322f545 の修正で正常にフォーマットされるようになったようです
melpon
approved these changes
Feb 19, 2024
|
よさそう |
|
レビューありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.