成功時の Slack 通知を止める

shiguredo · Jan 7, 2025 · 34e42aa · 34e42aa
1 parent 26e578b
commit 34e42aa
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
@@ -102,19 +102,19 @@ jobs:
       - run: uv sync
       - run: uv run pytest -s
 
-  slack_notify_succeeded:
-    needs: [e2e_test_ubuntu, e2e_test_macos, e2e_test_windows]
-    runs-on: ubuntu-24.04
-    if: success()
-    steps:
-      - name: Slack Notification
-        uses: rtCamp/action-slack-notify@v2
-        env:
-          SLACK_CHANNEL: sora-python-sdk
-          SLACK_COLOR: good
-          SLACK_TITLE: SUCCEEDED
-          SLACK_ICON_EMOJI: ":star-struck:"
-          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+  # slack_notify_succeeded:
+  #   needs: [e2e_test_ubuntu, e2e_test_macos, e2e_test_windows]
+  #   runs-on: ubuntu-24.04
+  #   if: success()
+  #   steps:
+  #     - name: Slack Notification
+  #       uses: rtCamp/action-slack-notify@v2
+  #       env:
+  #         SLACK_CHANNEL: sora-python-sdk
+  #         SLACK_COLOR: good
+  #         SLACK_TITLE: SUCCEEDED
+  #         SLACK_ICON_EMOJI: ":star-struck:"
+  #         SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
 
   slack_notify_failed:
     needs: [e2e_test_ubuntu, e2e_test_macos, e2e_test_windows]

diff --git a/CHANGES.md b/CHANGES.md
@@ -15,3 +15,5 @@
 
 - [CHANGE] GitHub Actions の ubuntu-latest を ubuntu-24.04 に変更
   - @voluntas
+- [CHANGE] E2E テスト成功時に slack 通知をしないようにする
+  - @voluntas