Simply return value after write in active_record container backend
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where `#read` is overwritten by the cache plugin and therefore the container backend returns stale data. It should always return the value it wrote. Since `value` is never modified by this backend it makes no sense to read it again after setting it. Besides fixing the bug it might give a small perfomance boost, too. fixes https://github.com/shioyama/mobility/pull/543/files#r1944637671 thanks @dramalho for uncovering the bug and hints
|
Lovely, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply return
valueafter write in active_record container backendThis fixes a bug where
#readis overwritten by the cache plugin andtherefore the container backend returns stale data. It should always
return the value it wrote.
Since
valueis never modified by this backend it makes no sense toread it again after setting it.
Besides fixing the bug it might give a small perfomance boost, too.
fixes https://github.com/shioyama/mobility/pull/543/files#r1944637671
thanks @dramalho for uncovering the bug and hints