Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mag-fed shotgun + lever action syntax changes (#2302)
## About The Pull Request Very small pull request I could quickly do before work Adjusts some shotgun descriptions to not only be more accurate, but better organized syntactically. Does the same for lever-actions and also makes it so lever-action vocabulary respects my immersion Fixes a bug where the bulldog drum magazine would disappear because its update_icon was calling a null value. Also standardizes shotgun magazine checks (though I would like to refactor it at some point so we don't need a unique update_icon for every hecking magazine that has the two sprite states of "has bullets" and "doesn't") Final thing; ammo_boxes were not properly updating their sprites and descriptions when initialized. Now, every ammo box should have the proper sprite and description (including starting number of bullets) before they're interacted with. This technically makes load time a bit longer, but it shouldn't be noticeable. Also fixed spent shotgun shells being invisible and deleted an unused sprite in ammo_bullets.dmi ## Why It's Good For The Game Lever-action rifles have bullets and a lever, rather than shells and a pump. That's just an inherit moment being fixed. Shotgun changes make straight-mags actually not just worse drum magazines (fitting into webbings is super awesome!), and also better clarify what the items are. Also having to pop out a 9mm bullet out of a pistol magazine to slot one back in to make it look full is really, really annoying and misleading. Not being able to know how many bullets a magazine or ammo box has until its contents are interacted with is also bad for readability ## Changelog :cl: balance: Standard 12g box magazines are now small-sized, rather than normal spellcheck: Adjusts mag-based shotguns, lever-actions, and shotgun mag descriptions to be more efficient/accurate code: Changes how bulldog/mastiff magazines check for their icon to be standardized with the CM-15 code: All ammo_boxes now update_appearance upon being initialized fix: Bulldog drum magazines should no longer go invisible while checking for a base_icon_sprite that doesn't exist fix: Spent shotgun shells now have proper sprite pathing /:cl:
- Loading branch information