Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planetary Lighting Colors #3419

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

screencaps

dreamseeker_4Gp6mnCDNE
dreamseeker_ESzoX9zGLQ
dreamseeker_0ew77loMC0
dreamseeker_bZA16gvMeA
dreamseeker_V7WYCRWN4v
dreamseeker_iTCBsMqMuL
dreamseeker_FGH6nwSdCk

Adds some planetary lighting defines and applies them to relevant planets. I had noticed I had an old pr that did this (among other things) so I ripped this out.
Values are entirely subject to change I don't remember where I got them from and I'm not a so called 'colour theorist'

As a coincidence planetary turf files are cleaned up a little by this.

Why It's Good For The Game

A little bit of atmosphere fluff.

Changelog

🆑
add: Some planets now have new lighting values. Please report back on if they are "Pleasant"
/:cl:

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. DME Edit Code change Watch something violently break. labels Sep 23, 2024
@Erikafox
Copy link
Contributor Author

guh??

@Erikafox Erikafox marked this pull request as draft September 23, 2024 22:33
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 23, 2024
@Erikafox Erikafox marked this pull request as ready for review September 23, 2024 22:37
@Erikafox Erikafox requested a review from a team as a code owner September 23, 2024 22:50
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Sep 23, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 29, 2024
Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very pretty but has some linters to sort out

@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label Oct 7, 2024
@FalloutFalcon FalloutFalcon removed the Test Merge Required They'll have to do it for free. label Oct 17, 2024
Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

code/game/objects/effects/glowshroom.dm Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants