Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balaclavas Aren't Gas Masks #3609

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Oct 21, 2024

About The Pull Request

Addresses a longstanding pet peeve of mine. As originally implemented military balaclavas were just better gas masks. Now they just function as normal breath masks that can hide your identity, providing no passive gas protection nor hailer functionality. Also rewrites the description for the regular balaclava to no longer be a joke.

Why It's Good For The Game

actual gas masks should be useful enough to justify using them instead of balaclavas when gas is about

Changelog

🆑
balance: Balaclavas and half masks are now just breath masks, not gas masks
balance: Normal balaclavas can use internals too
fix: Balaclavas don't have a joke description anymore
iconadd: mask-up sprites for NGR balaclavas and masks
/:cl:

@Apogee-dev Apogee-dev requested review from a team as code owners October 21, 2024 00:00
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Oct 21, 2024
@FalloutFalcon
Copy link
Contributor

I do agree with this change but like the issue is irl you would just be able to layer these 2 together. I would honestly have a balaclava that has an integrated gas mask as a distinct item.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Apogee-dev
Copy link
Contributor Author

Apogee-dev commented Oct 23, 2024

I do agree with this change but like the issue is irl you would just be able to layer these 2 together. I would honestly have a balaclava that has an integrated gas mask as a distinct item.

If you mean a half gas mask over a balaclava, sure, it'd work, although I don't want to for reasons elaborated on below. If you mean a full gas mask over a balaclava I’m not sure there’s actually any point since the balaclava would not be visible and gas masks already anonymize the wearer, so they the same core functionality (and more).
The other issue is I wanted gas masks that actually offer passive gas/smoke protection to be normal-sized items. Stuff you find in armories and fire lockers, not a piece of equipment you’ll keep in your backpack or wear casually 24/7. The mere existence and accessibility of a small gas mask would kind of render those pointless outside of aesthetics, which kind of sucks and substantially reduces the credibility of gas and smoke as actual dangers.
With this PR that’s actually the case, with the only notable exception being sec hailers…. which are mostly unused (and should be reworked or removed imho, since it’s not like the hailing function is useful in regular gameplay). That, and if you're gasproof you should look the part rather than looking like any other mook.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants