-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go1.21 and update dependencies #149
Conversation
@shipwright-io/operator-approvers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about k8s/client-go. In addition. please provide a descriptive title which indicates this fixes a CVE.
k8s.io/api v0.27.4 | ||
k8s.io/apiextensions-apiserver v0.27.4 | ||
k8s.io/apimachinery v0.27.4 | ||
k8s.io/client-go v1.5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure client-go is aligned with the other k8s versions. This will break things otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is a replcaement directive for client-go
k8s.io/client-go => k8s.io/client-go v0.26.8
the k8s.io/client-go v1.5.2 is forced by go mod algorithm
I can see the same thing for the tekton operator go mod https://github.com/tektoncd/operator/blob/main/go.mod#L33
Also, it is worth adding that i tested it locally and it is working correctly
@shipwright-io/operator-reviewers |
/assign @coreydaley |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE