Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade shipwright-io/build to v0.13.0 #216

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Upgrade shipwright-io/build to v0.13.0 #216

merged 2 commits into from
Jun 7, 2024

Commits on Jun 7, 2024

  1. Update shipwright-io/build to v0.13.0 

    Update the Shipwright APIs to use v0.13.0 as their baseline. This
pulled in the following dependency updates:

- k8s.io/* to v0.27.11. This corresponds to Kubernets 1.27.11 code.
- sigs.k8s.io/controller-runtime to v0.15.3

Signed-off-by: Adam Kaplan <[email protected]>
    @adambkaplan
    adambkaplan committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b345250 View commit details
    Browse the repository at this point in the history

  2. Modifications from Dependency Updates 

    Upgrading to k8s 1.27 required a similar update to the version
Envtest simulates. While testing this locally, I discovered that the
latest branch of the setup-envtest tool requires golang 1.22. Using
the older `release-0.17` branch bypasses this issue for now.

After the update, some of the tests in
`TestShipwrightBuildReconciler_Reconcile` fail permanently. These
were previously marked as "brittle" because they used separate k8s test
clientsets. These tests are now skipped, resulting in loss of test
coverage related to operand image overrides. A refactor is in order to
ensure we only use the controller-runtime clientsets. This should come
after the upgrade to operator-sdk, which will require a restructure of
the project.

The update also exposed a latent bug in our controller logic, related
to updating the ShipwrightBuild object status. We previously were not
requeing on error, which in production can happen for a wide variety
of reasons. This bug was in fact caught by a lint check that was
skipped; this bypass has been removed to ensure we don't regress in
the future.
    @adambkaplan
    adambkaplan committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    811604b View commit details
    Browse the repository at this point in the history