add support for get disk serial number on darwin #1791
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirou
requested changes
Feb 20, 2025
| @@ -88,8 +91,60 @@ func getFsType(stat unix.Statfs_t) string { | |||
| return common.ByteToString(stat.Fstypename[:]) | |||
| } | |||
|
|
|||
| type SPNVMeDataTypeItem struct { | |||
There was a problem hiding this comment.
Could you change to a private struct?
| func SerialNumberWithContext(ctx context.Context, name string) (string, error) { | ||
| return "", common.ErrNotImplementedError | ||
| cmd := exec.Command("system_profiler", "SPNVMeDataType", "-json") |
There was a problem hiding this comment.
Could you change to use invoker.CommandWithContext() like here?
Comment on lines
+130
to
+133
| err = json.Unmarshal(output, &temp) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to unmarshal JSON: %w", err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| err = json.Unmarshal(output, &temp) | |
| if err != nil { | |
| return "", fmt.Errorf("failed to unmarshal JSON: %w", err) | |
| } | |
| if err := json.Unmarshal(output, &temp); err != nil { | |
| return "", fmt.Errorf("failed to unmarshal JSON: %w", err) | |
| } |
Comment on lines
+124
to
+128
| var temp struct { | ||
| SPNVMeDataType []struct { | ||
| Items []SPNVMeDataTypeItem `json:"_items"` | ||
| } `json:"SPNVMeDataType"` | ||
| } |
There was a problem hiding this comment.
How about defining the struct at the top level instead of dynamically defining it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first PR on this project, so let me know if I got anything wrong and should change it.
This fixes #801 and adds support for getting (NVMe) drives' serial number. It does this by executing system_profiler and unmarshalling.