Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 14.0 SO transaction amount: remove paid amount #79

Open
wants to merge 3 commits into
base: 14.0
Choose a base branch
from

Conversation

PierrickBrun
Copy link

While creating the transaction, shopinvader_payment uses the sale_order amount_total.

This works well when using 1 transaction. But when using several transactions, all of them are created with amount_total as amount.

It should be decremented, this is what this PR does

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 87.12% // Head: 85.96% // Decreases project coverage by -1.15% ⚠️

Coverage data is based on head (ac4087e) compared to base (7059f93).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             14.0      #79      +/-   ##
==========================================
- Coverage   87.12%   85.96%   -1.16%     
==========================================
  Files          38       50      +12     
  Lines         396      506     +110     
  Branches       42       60      +18     
==========================================
+ Hits          345      435      +90     
- Misses         38       57      +19     
- Partials       13       14       +1     
Impacted Files Coverage Δ
shopinvader_payment/models/sale_order.py 93.33% <0.00%> (-6.67%) ⬇️
...pinvader_payment/services/abstract_payable_sale.py 100.00% <100.00%> (ø)
...nvader_payment/services/invader_payment_service.py 78.26% <0.00%> (-0.32%) ⬇️
shopinvader_payment/services/cart.py 100.00% <0.00%> (ø)
shopinvader_payment/services/__init__.py 100.00% <0.00%> (ø)
invader_payment/models/invader_payable.py 100.00% <0.00%> (ø)
shopinvader_payment/tests/test_payment.py 100.00% <0.00%> (ø)
invader_invoice_payment/models/__init__.py 100.00% <0.00%> (ø)
...er_payment_condition/models/shopinvader_payment.py 100.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebastienbeau sebastienbeau added this to the 14.0 milestone Jun 5, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants