Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] Api to list payment methods #91

Open
wants to merge 3 commits into
base: 14.0
Choose a base branch
from

Conversation

cristiano-one
Copy link

This module lists payment methods that have been added to the Shopinvader Backend.

def list_payment_method(self, **params):
"""Generates a list of available payment methods"""
shopinvader_payments_released = (
self.shopinvader_backend.payment_method_ids

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shopinvader_backend doesn't exist and shouldn't exist in an invader_* module.
Maybe you should move this into your new shopinvader_* related module.

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
"name": "",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty?

# Copyright 2022 KMEE
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
{
"name": "Shopinvader REST Services for list payment methods (REST, Base)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shopinvader => invader

[("name", "=", "Demo Shopinvader Website")]
)
backend_one.payment_method_ids.create(
{"code": "PayPal", "acquirer_id": 8, "backend_id": 1}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ You can not hard-code id.

@sebastienbeau sebastienbeau added this to the 14.0 milestone Jun 5, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants