[16.0][ADD] addon shopinvader_api_address #1361

AnizR · 2023-06-06T10:41:50Z

Depends on OCA/rest-framework#348 for tests.

Addon to manipulate shipping/billing addresses linked to authenticated_partner

The authenticated_partner is a shipping and a billing address. Thus, there will always be at least one billing and shipping address when there is an authenticated_partner (given the fact that the address is complete/has enough information to be a shipping/billing address) will be done in front of shopinvader
Add fastapi tags

The billing address is unique and is the authenticated_partner. Therefore, it is impossible to delete it
The shipping addresses have no restriction

shopinvader_api_address/routers/address_service.py

shopinvader_api_address/schema/schema.py

shopinvader_api_address/tests/test_shopinvader_address_api.py

shopinvader_api_address/models/res_partner.py

shopinvader_schema_address/schema/address.py

shopinvader_api_address/models/fast_api_endpoint.py

shopinvader_api_address/models/res_partner.py

shopinvader_schema_address/schema/address.py

shopinvader_api_address/schema/schema.py

shopinvader_api_address/routers/__init__.py

shopinvader_api_address/security/res_groups.xml

shopinvader_api_address/models/res_partner.py

shopinvader_schema_address/schemas.py

shopinvader_api_address/schemas.py

shopinvader_api_address/models/res_partner.py

shopinvader_schema_address/schemas.py

shopinvader_address/models/res_partner.py

shopinvader_api_address/routers/address_service.py

shopinvader_address/models/res_partner.py

sbidoul · 2023-06-22T16:25:29Z

shopinvader_api_address/security/snailmail_letter.xml

+    <!-- allow authenticated partner to snailmail_letter where it is used-->
+    <record id="shopinvader_address_snailmail_letter_rule" model="ir.rule">
+        <field name="name">Shopinvader Address Endpoint rule: snailmail_letter</field>
+        <field name="model_id" ref="snailmail.model_snailmail_letter" />


To investigate. If this rule stays then shopinvader_api_address must depend on snailmail, which would be... not good.

Indeed, I will remove it.

I added this because a check is done in snailmail in write of res.partner : https://github.com/odoo/odoo/blob/a4e3662351420b9b87eac386d6bd7b4f075d9fa9/addons/snailmail/models/res_partner.py#LL20C9-L20C9

The problem is that the access to the model snailmail_letter is given to only base.group_user and base.group_system. In our case, we don't want to give any of those group to the endpoint's user (too much rights).

(IMO, an issue can (and will) be created on Odoo regarding the fact that the check should be done in sudo() + I think that the fact that every user can read every snailmail_letter is also an issue.. )

To tackle this problem, I think that the best option is to call in sudo mode our functions that does a write on res.partner in our services (in the module shopinvader_api_address).

shopinvader_address/models/res_partner.py

sbidoul · 2023-06-26T17:15:21Z

This is the v2 address service, ready for final review. @sebastienbeau @thibaultrey @hparfr

A few notes:

the patterns applied here are explained above: [16.0][ADD] addon shopinvader_api_address #1361 (review)
in the current implementation, the billing address is unique and is the authenticated partner (can be overridden)
DELETE does not delete but archives the address
to understand how to extend this code, see [ADD][16.0] address shipping note #1374 that adds a field to the address

FrancoMaxime

LGTM

shopinvader_address/models/res_partner.py

shopinvader_api_address/__manifest__.py

shopinvader_address/models/res_partner.py

author Zina Rasoamanana <[email protected]> 1686047094 +0200 committer Zina Rasoamanana <[email protected]> 1688136067 +0200 [ADD] addon shopinvader_schema_address: init wip: add addres_billing/shipping get/create update shipping address work on tests + use country/state_id + work on address schemas rename address service extract service logic from model extract shopinvader_address some improvements + sudo on service write add vat on billing address split create/update shipping address check before update/delete shipping address readme shopinvader_schema_address shopinvader_api_address readme shopinvader_address: readme [FIX] shopinvader_api_address_*: Uses new helper class to run tests with fastapi and extendable

AnizR · 2023-06-30T14:47:29Z

I cleaned up my commits history @xavier-bouquiaux @marielejeune, you may need to rebase your branches

marielejeune · 2023-07-26T11:31:25Z

Main changes concern the following modification:

Pydantic v2 now makes a distinction between nullable fields and required fields.

vat: str | None makes the vat attr nullable but required. Hence we must add default None value (= None) to make it not required.

See here for more details

lmignon · 2023-07-26T11:49:46Z

/ocabot merge nobump

shopinvader-git-bot · 2023-07-30T13:21:37Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot · 2023-07-30T13:21:39Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot · 2023-07-30T13:22:01Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1361-by-lmignon-bump-nobump, awaiting test results.

shopinvader-git-bot · 2023-07-30T13:57:00Z

Congratulations, your PR was merged at b9da4d8. Thanks a lot for contributing to shopinvader. ❤️

AnizR marked this pull request as draft June 6, 2023 10:41

AnizR force-pushed the acsone/16.0-api-address branch 6 times, most recently from 116320d to c48067e Compare June 7, 2023 10:23

sebastienbeau added this to the 16.0 milestone Jun 9, 2023

marielejeune mentioned this pull request Jun 16, 2023

[MIG] shopinvader_api_cart (sale_cart_rest_api to FastAPI) #1369

Merged

9 tasks

AnizR commented Jun 20, 2023

View reviewed changes

lmignon reviewed Jun 20, 2023

View reviewed changes

shopinvader_api_address/models/fast_api_endpoint.py Outdated Show resolved Hide resolved

lmignon reviewed Jun 20, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

lmignon reviewed Jun 20, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

lmignon reviewed Jun 20, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

marielejeune reviewed Jun 20, 2023

View reviewed changes

shopinvader_schema_address/schema/address.py Outdated Show resolved Hide resolved

marielejeune reviewed Jun 20, 2023

View reviewed changes

shopinvader_schema_address/schema/address.py Outdated Show resolved Hide resolved

marielejeune reviewed Jun 20, 2023

View reviewed changes

shopinvader_api_address/schema/schema.py Outdated Show resolved Hide resolved

marielejeune reviewed Jun 21, 2023

View reviewed changes

shopinvader_api_address/routers/__init__.py Show resolved Hide resolved

marielejeune reviewed Jun 21, 2023

View reviewed changes

shopinvader_api_address/security/res_groups.xml Outdated Show resolved Hide resolved

AnizR commented Jun 21, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

marielejeune reviewed Jun 21, 2023

View reviewed changes

shopinvader_schema_address/schemas.py Outdated Show resolved Hide resolved

sbidoul reviewed Jun 21, 2023

View reviewed changes

shopinvader_api_address/schemas.py Outdated Show resolved Hide resolved

sbidoul reviewed Jun 21, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

sbidoul reviewed Jun 21, 2023

View reviewed changes

shopinvader_api_address/models/res_partner.py Outdated Show resolved Hide resolved

sbidoul reviewed Jun 21, 2023

View reviewed changes

shopinvader_schema_address/schemas.py Outdated Show resolved Hide resolved

AnizR changed the title ~~[ADD] addon schema_address: init~~ [WIP][ADD] addon shopinvader_api_address Jun 22, 2023

AnizR commented Jun 22, 2023

View reviewed changes

shopinvader_schema_address/schemas.py Show resolved Hide resolved

sbidoul reviewed Jun 22, 2023

View reviewed changes

shopinvader_address/models/res_partner.py Outdated Show resolved Hide resolved

sbidoul reviewed Jun 22, 2023

View reviewed changes

sbidoul reviewed Jun 26, 2023

View reviewed changes

shopinvader_address/models/res_partner.py Show resolved Hide resolved

sbidoul marked this pull request as ready for review June 26, 2023 16:59

FrancoMaxime reviewed Jun 27, 2023

View reviewed changes

sbidoul changed the title ~~[WIP][ADD] addon shopinvader_api_address~~ [16.0][ADD] addon shopinvader_api_address Jun 29, 2023

xavier-bouquiaux mentioned this pull request Jun 29, 2023

[WIP][14][BACKPORT] shopinvader api address #1380

Closed

AnizR force-pushed the acsone/16.0-api-address branch from f477d19 to 14d25da Compare June 30, 2023 14:42

AnizR force-pushed the acsone/16.0-api-address branch from 14d25da to 0bef327 Compare June 30, 2023 14:45

Migration to Pydantic v2

3b55bd4

lmignon approved these changes Jul 26, 2023

View reviewed changes

lmignon assigned AnizR Jul 26, 2023

lmignon added the approved label Jul 26, 2023

shopinvader-git-bot added the ready to merge label Jul 30, 2023

shopinvader-git-bot removed approved ready to merge labels Jul 30, 2023

shopinvader-git-bot added the bot is merging ⏳ label Jul 30, 2023

shopinvader-git-bot merged commit 993375a into shopinvader:16.0 Jul 30, 2023
3 checks passed

shopinvader-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 30, 2023

sbidoul deleted the acsone/16.0-api-address branch July 30, 2023 14:14

sbidoul mentioned this pull request Oct 17, 2023

[16.0] shopinvader_api_address: refactor API (paginate, code improvement #1425

Closed

7 tasks

sbidoul mentioned this pull request Nov 3, 2023

shopinvader_api_address: support partial update #1443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] addon shopinvader_api_address #1361

[16.0][ADD] addon shopinvader_api_address #1361

AnizR commented Jun 6, 2023 •

edited

Loading

sbidoul Jun 22, 2023

AnizR Jun 22, 2023

sbidoul commented Jun 26, 2023

FrancoMaxime left a comment

AnizR commented Jun 30, 2023

marielejeune commented Jul 26, 2023 •

edited

Loading

lmignon commented Jul 26, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

[16.0][ADD] addon shopinvader_api_address #1361

[16.0][ADD] addon shopinvader_api_address #1361

Conversation

AnizR commented Jun 6, 2023 • edited Loading

sbidoul Jun 22, 2023

Choose a reason for hiding this comment

AnizR Jun 22, 2023

Choose a reason for hiding this comment

sbidoul commented Jun 26, 2023

FrancoMaxime left a comment

Choose a reason for hiding this comment

AnizR commented Jun 30, 2023

marielejeune commented Jul 26, 2023 • edited Loading

lmignon commented Jul 26, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

shopinvader-git-bot commented Jul 30, 2023

AnizR commented Jun 6, 2023 •

edited

Loading

marielejeune commented Jul 26, 2023 •

edited

Loading