[16.0][ADD] shopinvader_v2_app_demo #1364
Conversation
AnizR
force-pushed
the
16.0-shopinvader-api-demo
branch
from
e3fabe2
to
f5d25d6
Compare
|
@sebastienbeau |
AnizR
force-pushed
the
16.0-shopinvader-api-demo
branch
2 times, most recently
from
0a3dab1
to
312fed2
Compare
AnizR
changed the title
|
Can we continue your work with @lmignon ? |
yes, no problem :) |
AnizR
changed the title
marielejeune
force-pushed
the
16.0-shopinvader-api-demo
branch
2 times, most recently
from
818029a
to
3f77487
Compare
marielejeune
force-pushed
the
16.0-shopinvader-api-demo
branch
2 times, most recently
from
f48391f
to
a2ea147
Compare
sbidoul
force-pushed
the
16.0-shopinvader-api-demo
branch
4 times, most recently
from
dd0b933
to
aea4583
Compare
| ) | ||
| auth_jwt_validator_id = fields.Many2one("auth.jwt.validator") | ||
|
|
||
| @api.model |
There was a problem hiding this comment.
Shouldn't be an api.model
marielejeune
force-pushed
the
16.0-shopinvader-api-demo
branch
from
dbd3a7c
to
2da4d5c
Compare
AnizR
changed the title
lmignon
force-pushed
the
16.0-shopinvader-api-demo
branch
5 times, most recently
from
84f6d15
to
02880ac
Compare
* Declares clientId * Uses a fixed version of base_rest supporting the oauth rediretion for swagger-ui
The simple case is to have 1 and only 1 backend
We should have everything we need in new API now.
sbidoul
force-pushed
the
16.0-shopinvader-api-demo
branch
from
981ba47
to
aeae920
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
LGTM (code review)
I think we should merge this and then when need creating PR for improving it
Note: when auth_partner will be merged I think it will be better to move on it for the authentication instead of the keycloak one (the purpose of this module is to make a demo, so less tool, less external requirement is always better, but we can still have an extra module *_demo_jwt for demo with keycloak)
|
/ocabot merge nobump |
Demo, but also serve as a template for a new project so let's keep that in mind. |
|
This PR looks fantastic, let's merge it! |
|
@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1364-by-sbidoul-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Adds a demo application on fastapi endpoint for a demo shopinvader application that takes every router
Side note: when adding new routers, we should include them in this module