[16.0][MIG] shopinvader_search_engine: Migration to 16.0 + REFACTORING

[qgroulard]

No description provided.

[sebastienbeau]

@qgroulard can you check the lint and the reason of the failling test.

It will be great to merge this PR, as it introduce shopinvader_product.

Thanks

[qgroulard]

@qgroulard can you check the lint and the reason of the failling test.

It will be great to merge this PR, as it introduce shopinvader_product.

Thanks

I still have a bit of work here. Few open points will be discussed with lmignon today.

I'll keep you posted and make this PR ready asap.

[hparfr]

thanks for this work @qgroulard

In order to keep the discussion in one place, let continue on #1386, specifically about:

1. the product/category link with shopinvader_backend
2. if _compute_main_product deserve it's own module (in oca)

[hparfr]

are you sure it's still needed ?

there was some changes between v14 and v16 in product regarding the price calculation

[hparfr]

odoo/odoo@b6e2637

[qgroulard]

seo_title used to be computed based on the backend's website name.
What should we do now ?

odoo-shopinvader/shopinvader/models/shopinvader_product.py

Lines 72 to 80 in 24db291

	def _build_seo_title(self):
	"""
	Build the SEO product name
	:return: str
	"""
	self.ensure_one()
	return "{} | {}".format(
	self.name or "", self.backend_id.website_public_name or ""
	)

[lmignon]

seo_title used to be computed based on the backend's website name. What should we do now ?

odoo-shopinvader/shopinvader/models/shopinvader_product.py

Lines 72 to 80 in 24db291

	def _build_seo_title(self):
	"""
	Build the SEO product name
	:return: str
	"""
	self.ensure_one()
	return "{} | {}".format(
	self.name or "", self.backend_id.website_public_name or ""
	)

🤔 🤔 🤔 🤔 🤔 🤔 🤔

What about adding a new seo_title_postfix field on the search_engine backend? (translatable=True?)

@sebastienbeau @hparfr

[hparfr]

What about adding a new seo_title_postfix field on the search_engine backend? (translatable=True?)

@sebastienbeau @hparfr

In which module ?

[hparfr]

hi

Have you seen this pr https://github.com/OCA/sale-channel/pull/7/files#diff-aa8725b71193423d895954631ef05a6d125aae74feb2242645d1c4ae4357a676R20 ?

It already contain all the needed logic to select products and categories for se export, it also implement levels and filters categories.

For working with shopinvader, it needs a base module for the creation of an ir_export and a is a serializer_type (previously it was the shopinvader module, it may be replaced by a bare minimum shopinvader_product module
and a glue module for adding ir_export_lines.

You can checkout this branch, it's based on restapi: https://github.com/akretion/odoo-shopinvader/tree/16.0-shopinvader-sale-channel

[qgroulard]

hi

Have you seen this pr https://github.com/OCA/sale-channel/pull/7/files#diff-aa8725b71193423d895954631ef05a6d125aae74feb2242645d1c4ae4357a676R20 ?

It already contain all the needed logic to select products and categories for se export, it also implement levels and filters categories.

For working with shopinvader, it needs a base module for the creation of an ir_export and a is a serializer_type (previously it was the shopinvader module, it may be replaced by a bare minimum shopinvader_product module and a glue module for adding ir_export_lines.

You can checkout this branch, it's based on restapi: https://github.com/akretion/odoo-shopinvader/tree/16.0-shopinvader-sale-channel

Hi,
I don't think we need to depend on sale_channel to compute parent and children categories.
IMO these fields belong here, whatever source able to give the index (e.g. the sale_channel) can pass it in the context and the fields will be computed accordingly.

[lmignon]

/ocabot merge nobump

[lmignon]

/ocabot merge nobump

[lmignon]

/ocabot merge nobump

[lmignon]

/ocabot merge nobump

[hparfr]

/ocabot merge nobump

[hparfr]

looks like the bot is sleeping.

btw, some of my remarks are not adressed; such as the get_price()

[lmignon]

looks like the bot is sleeping.

btw, some of my remarks are not adressed; such as the get_price()

The price is in the roadmap. It will be taken into account in an other PR. We need to move forward since we've tons of PR linked to each others and it's now difficult to have a clear view of all the work already done.

[shopinvader-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1390-by-lmignon-bump-nobump, awaiting test results.

[shopinvader-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1390-by-lmignon-bump-nobump, awaiting test results.

[shopinvader-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1390-by-lmignon-bump-nobump, awaiting test results.

[shopinvader-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1390-by-lmignon-bump-nobump, awaiting test results.

[shopinvader-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1390-by-hparfr-bump-nobump, awaiting test results.

[shopinvader-git-bot]

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1390-by-lmignon-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[shopinvader-git-bot]

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1390-by-hparfr-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[shopinvader-git-bot]

Congratulations, your PR was merged at b1e1284. Thanks a lot for contributing to shopinvader. ❤️

[qgroulard]

What about adding a new seo_title_postfix field on the search_engine backend? (translatable=True?)
@sebastienbeau @hparfr

In which module ?

I've opened this PR: #1434