[16.0][MIG] shopinvader_api_delivery_carrier: FastAPI services #1479
Conversation
marielejeune
force-pushed
the
16.0-shopinvader_api_delivery_carrier-mle
branch
from
6d04350
to
90196b1
Compare
marielejeune
changed the title
marielejeune
force-pushed
the
16.0-shopinvader_api_delivery_carrier-mle
branch
4 times, most recently
from
4328f2f
to
4175e9f
Compare
marielejeune
force-pushed
the
16.0-shopinvader_api_delivery_carrier-mle
branch
3 times, most recently
from
c5eda37
to
97148ca
Compare
marielejeune
changed the title
marielejeune
force-pushed
the
16.0-shopinvader_api_delivery_carrier-mle
branch
from
97148ca
to
41db857
Compare
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
There was a problem hiding this comment.
shouldn't RR go to their own module?
There was a problem hiding this comment.
This was done for principal modules, but not everywhere (for eg. RR are in shopinvader_api_sale_loyalty).
@lmignon what's your opinion about it?
There was a problem hiding this comment.
It's fine to get it here. We try to get a proper security declaration by api.... This addon comes with its own security group. If a same alc is defined multiple time across different addon we could create a common addon but is-it really better to get one addon for one ACL?
| cls.partner = cls.env["res.partner"].create( | ||
| {"name": "FastAPI Delivery Carrier Demo"} | ||
| ) | ||
| cls.user_with_rights = cls.env["res.users"].create( |
There was a problem hiding this comment.
always set no_reset_password in ctx when creating users (or use new_test_user from odoo.tests.common)
There was a problem hiding this comment.
Done (using new_test_user)
|
|
||
|
|
||
| @delivery_carrier_router.get("/{uuid}/delivery_carriers") | ||
| @delivery_carrier_router.get("/current/delivery_carriers") |
There was a problem hiding this comment.
I keep seeing this current... what's the point of it? I know it comes from the cart endpoint but I don't get why we need a specific key to default to the last used cart.
There was a problem hiding this comment.
Because the default route @delivery_carrier_router.get("/delivery_carriers") is used to return all delivery carriers, not only the ones applicable to the current cart.
marielejeune
force-pushed
the
16.0-shopinvader_api_delivery_carrier-mle
branch
from
41db857
to
f565433
Compare
|
This PR has the |
|
Modules moved to odoo-shopinvader-carrier shopinvader/odoo-shopinvader-carrier#8 |
Migration of
shopinvader_delivery_carrierto FastAPI services.shopinvader_delivery_carriercontains the Shopinvader logic related to delivery.shopinvader_api_delivery_carriercontains all FastAPI schemas and services:delivery_carrierrouter, with a route to search ondelivery.carrier, filtering by country and/or zipcode.deliveryrouter, with a route to search on all pickings related to the user.set_carrierroute under thecartrouter, to set the carrier on the cart.syncroute under thecartrouter that removes the carrier on the cart everytime a new transaction is synchronized.Features & changes
This is a migration to version 16 of
shopinvader_delivery_carrierbut combined with a rewriting to FastAPI, which means that some features are not integrated (yet?). Here is a summary of the differences:shopinvader.backendto configure which delivery order states are visible. This configuration was used to filter the visible pickings on the front side.The notion of shopinvader backend is not kept in v16 and we don't need this configuration for now, so we don't preserve it here.
deliveriesto download thestock.action_report_deliveryreport. We didn't keep this feature for now.Here the route is authenticated so the partner will never be anonymous.