[16.0][IMP] shopinvader_api_cart: add GET /current , POST /current/sync and /current/update routes #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
changed the title
|
Looks good, but tests are failing. |
… /current/update routes
This is done to avoid problems when adding new routes, such as /payable,
that would conflict with /{uuid}.
marielejeune
force-pushed
the
16.0-shopinvader_api_cart-mle
branch
from
6e1381f
to
dc1ab95
Compare
Fixed. The routes ordering is important! |
lmignon
approved these changes
Jan 18, 2024
|
@lmignon I think this one can be merged too |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 50ec091. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to avoid problems when adding new routes, such as /payable, that would conflict with /{uuid}.