Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] shopinvader_schema_sale: sale_line qty rounding #1503

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[16.0][IMP] shopinvader_schema_sale: sale_line qty rounding #1503

merged 1 commit into from
Jun 4, 2024

Conversation

qgroulard
Copy link
Contributor

No description provided.

@qgroulard qgroulard force-pushed the 16.0-imp-sale_line_schema_qty_rounding-qgr branch from e545936 to 5964fd8 Compare February 20, 2024 12:41
@sebastienbeau sebastienbeau added this to the 16.0 milestone Jun 3, 2024
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Collaborator

lmignon commented Jun 3, 2024

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1503-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 3, 2024
Merge PR #1503 into 16.0
e4ae2c0 
Signed-off-by lmignon
@shopinvader-git-bot
Copy link

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1503-by-lmignon-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

lmignon
lmignon requested changes Jun 3, 2024
View reviewed changes
shopinvader_schema_sale/schemas/sale_line.py Outdated
@@ -20,5 +22,8 @@ def from_sale_order_line(cls, odoo_rec):
product_id=odoo_rec.product_id.id,
name=odoo_rec.name,
amount=SaleLineAmount.from_sale_order_line(odoo_rec),
qty=odoo_rec.product_uom_qty,
qty=float_round(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must use json_float_round

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@qgroulard qgroulard force-pushed the 16.0-imp-sale_line_schema_qty_rounding-qgr branch from 5964fd8 to e354bf7 Compare June 4, 2024 08:59
@qgroulard qgroulard force-pushed the 16.0-imp-sale_line_schema_qty_rounding-qgr branch from e354bf7 to d44b9c4 Compare June 4, 2024 10:11
@lmignon
Copy link
Collaborator

lmignon commented Jun 4, 2024

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1503-by-lmignon-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 6162b87 into shopinvader:16.0 Jun 4, 2024
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 7896b53. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 16.0-imp-sale_line_schema_qty_rounding-qgr branch June 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwillig benwillig benwillig approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@qgroulard @shopinvader-git-bot @lmignon @benwillig @sebastienbeau