[14][IMP] shopinvader_sale_coupon : cast bool skip_coupon_recompute #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem from our client the cart update_item methods requires skip_coupon_recompute to be a boolean while the rest (item_id, item_qty) can be string. We are facing troubles due to this constraint, it will be better to accept string for the skip_coupon_recompute as well. So we won’t need to cast the value every where we use the method
xavier-bouquiaux
changed the title
acsonefho
approved these changes
Mar 14, 2024
|
@shopinvader/shopinvader-maintainers 🙏 |
|
Out of curiosity, why is it a problem for the client to pass a proper bool? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem from our client
the cart update_item methods requires skip_coupon_recompute to be a boolean while the rest (item_id, item_qty) can be string. We are facing troubles due to this constraint, it will be better to accept string for the skip_coupon_recompute as well. So we won’t need to cast the value every where we use the method
@acsonefho