Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] CI #1519

Merged
merged 3 commits into from
Mar 21, 2024
Merged

[16.0][FIX] CI #1519

merged 3 commits into from
Mar 21, 2024

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Mar 20, 2024

see odoo/odoo@65a1949

The payment must have the the journal as the payment_method
Due to a refactoring by Tecnativa of the sale_product_set addon on a stable branch, the model 'product.set.add' has been removed and replaced by 'sale.product.set.wizard'

See OCA/sale-workflow#3009
This addon is not installable by depends on removed addons. Due to a change into odoo the dependencies are checked despite the addon is declared as not installable. see odoo/odoo#141747
@lmignon
Copy link
Collaborator Author

lmignon commented Mar 20, 2024

ping @sebastienbeau @simahawk @qgroulard This PR fixes the CI. Pay attention to the breaking changes into the sale_product_set addon.

Copy link
Contributor

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

Thanks a lot Laurent for the fix !

@sebastienbeau
Copy link
Contributor

/ocabot merge patch

@lmignon
Copy link
Collaborator Author

lmignon commented Mar 21, 2024

/ocabot merge major

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1519-by-sebastienbeau-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 0ed656c into shopinvader:16.0 Mar 21, 2024
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 8085f76. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants