Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] Add sale_cart_step + shopinvader_api_cart_step #1521

Merged
merged 2 commits into from
May 6, 2024

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Mar 25, 2024

Addresses #1511

Depends on:

TODO: what to do w/ old shopinvader modules?
I'm not sure this is needed.
If you don't use sale_cart_step you won't need any migration.
TBH I'd like not to waste time on migrating shopinvader and/or shopinvader_restapi.

@simahawk simahawk force-pushed the 16-sale-cart-step branch 2 times, most recently from 0aca158 to 23b5c74 Compare March 25, 2024 15:12
@simahawk simahawk mentioned this pull request Apr 8, 2024
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cyrilmanuel
Copy link

hi @lmignon , can you merge this PR ?

shopinvader_api_cart/routers/cart.py Outdated Show resolved Hide resolved
@lmignon
Copy link
Collaborator

lmignon commented Apr 19, 2024

#1534 is merged....

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor Author

simahawk commented May 6, 2024

/ocabot merge nobump

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1521-by-simahawk-bump-nobump, awaiting test results.

@shopinvader-git-bot
Copy link

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1521-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@shopinvader-git-bot shopinvader-git-bot merged commit b3d27b5 into shopinvader:16.0 May 6, 2024
3 checks passed
@shopinvader-git-bot
Copy link

@simahawk The merge process could not be finalized, because command rsync -rv --ignore-existing --no-perms --chmod=ugo=rwX /tmp/tmpbona4pc9/ [email protected]:./odoo-addon-sale-cart-step/ failed with output:

kex_exchange_identification: read: Connection reset by peer
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(235) [sender=3.1.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants