Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [ADD] delivery price simulation for cart #488

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Oct 31, 2019

forward port of #352

@lmignon lmignon added the 12.0 label Oct 31, 2019
@lmignon lmignon mentioned this pull request Oct 31, 2019
77 tasks
@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #488 into 12.0 will increase coverage by 0.12%.
The diff coverage is 98.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #488      +/-   ##
==========================================
+ Coverage   91.58%   91.71%   +0.12%     
==========================================
  Files         111      113       +2     
  Lines        3127     3198      +71     
==========================================
+ Hits         2864     2933      +69     
- Misses        263      265       +2
Impacted Files Coverage Δ
shopinvader_delivery_carrier/controllers/main.py 80% <ø> (-5.72%) ⬇️
...ader_delivery_carrier/services/delivery_carrier.py 100% <100%> (ø)
...nvader_delivery_carrier/models/delivery_carrier.py 100% <100%> (ø)
shopinvader_delivery_carrier/services/cart.py 95.65% <93.75%> (+0.78%) ⬆️
...invader_delivery_carrier/services/abstract_sale.py 93.75% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714a11f...b2ee12b. Read the comment docs.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 31, 2019

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-488-by-lmignon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 31, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit b2ee12b into shopinvader:12.0 Oct 31, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at d4a8dbf. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-shopinvader_delivery_estimation branch October 31, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants