Migrate test YAML syntax to new data_test namespace to makeway for un…

…it_tests
shoppad · Apr 4, 2024 · e2df201 · e2df201
1 parent e22c717
commit e2df201
Show file tree

Hide file tree

Showing 55 changed files with 791 additions and 558 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/dbt-checkpoint/dbt-checkpoint
-    rev: v1.1.1
+    rev: v1.2.1
     hooks:
       - id: dbt-docs-generate
       - id: check-script-semicolon
@@ -11,7 +11,7 @@ repos:
       - id: generate-model-properties-file
         args: ["--properties-file", "./models/mesa/{name}.yml", "--"]
 
-      - id: unify-column-description
+      #- id: unify-column-description
       - id: check-column-name-contract
         args: [--pattern, "(is|has|do)_.*", --dtype, boolean]
       - id: check-model-has-all-columns

diff --git a/models/customer_io/staging/_stg_email_clicks.yml b/models/customer_io/staging/_stg_email_clicks.yml
@@ -1,15 +1,16 @@
 version: 2
-
 models:
   - name: stg_email_clicks
-    description: "Email clicks from Customer.io"
-    tags: ["staging", "customer_io"]
+    description: Email clicks from Customer.io
+    tags:
+      - staging
+      - customer_io
     columns:
-        - name: delivery_id
-          description: "Unique ID for the email delivery"
-          tests:
-            - not_null
-        - name: shop_subdomain
-          description: "Shopify subdomain"
-          tests:
-            - not_null
+      - name: delivery_id
+        description: Unique ID for the email delivery
+        data_tests:
+          - not_null
+      - name: shop_subdomain
+        description: The foreign key for the Shop.
+        data_tests:
+          - not_null
diff --git a/models/customer_io/staging/_stg_email_conversions.yml b/models/customer_io/staging/_stg_email_conversions.yml
@@ -1,15 +1,16 @@
 version: 2
-
 models:
   - name: stg_email_conversions
     description: Staging table for email conversion details
-    tags: ["staging", "customer_io"]
+    tags:
+      - staging
+      - customer_io
     columns:
-        - name: delivery_id
-          description: "Unique ID for the email delivery"
-          tests:
-            - not_null
-        - name: shop_subdomain
-          description: "Shopify subdomain"
-          tests:
-            - not_null
+      - name: delivery_id
+        description: Unique ID for the email delivery
+        data_tests:
+          - not_null
+      - name: shop_subdomain
+        description: The foreign key for the Shop.
+        data_tests:
+          - not_null
diff --git a/models/customer_io/staging/_stg_email_opens.yml b/models/customer_io/staging/_stg_email_opens.yml
@@ -1,15 +1,16 @@
 version: 2
-
 models:
   - name: stg_email_opens
-    description: "Email opens from Customer.io"
-    tags: ["staging", "customer_io"]
+    description: Email opens from Customer.io
+    tags:
+      - staging
+      - customer_io
     columns:
-        - name: delivery_id
-          description: "Unique ID for the email delivery"
-          tests:
-            - not_null
-        - name: shop_subdomain
-          description: "Shopify subdomain"
-          tests:
-            - not_null
+      - name: delivery_id
+        description: Unique ID for the email delivery
+        data_tests:
+          - not_null
+      - name: shop_subdomain
+        description: The foreign key for the Shop.
+        data_tests:
+          - not_null
diff --git a/models/generic/_currency_conversion_rates.yml b/models/generic/_currency_conversion_rates.yml
@@ -3,12 +3,12 @@ models:
   - name: currency_conversion_rates
     columns:
       - name: CURRENCY
-        tests:
+        data_tests:
           - not_null
           - unique
       - name: IN_USD
-        tests:
+        data_tests:
           - not_null
       - name: EXCHANGE_RATE_AT
-        tests:
+        data_tests:
           - not_null
diff --git a/models/generic/intermediate/_int_shop_infos.yml b/models/generic/intermediate/_int_shop_infos.yml
@@ -1,15 +1,15 @@
 version: 2
-
 models:
   - name: int_shop_infos
-    description: "Intermediate table for shop information"
-    tags: ["intermediate"]
+    description: Intermediate table for shop information
+    tags:
+      - intermediate
     columns:
       - name: shop_subdomain
-        description: Shopify subdomain
-        tests:
+        description: The foreign key for the Shop.
+        data_tests:
           - unique
       - name: updated_at
-        description: The date the shop info was updated.
-        tests:
+        description: Used to build incremental models.
+        data_tests:
           - not_null
diff --git a/models/generic/staging/_stg_constellation_users.yml b/models/generic/staging/_stg_constellation_users.yml
@@ -1,12 +1,13 @@
 version: 2
-
 models:
   - name: stg_constellation_users
-    description: >
-      This table contains all users in the ShopPad ecosystem.
-    tags: ["staging"]
+    description: "This table contains all users in the ShopPad ecosystem.
+
+      "
+    tags:
+      - staging
     columns:
       - name: shop_subdomain
-        description: Shopify subdomain
-        tests:
+        description: The foreign key for the Shop.
+        data_tests:
           - unique
diff --git a/models/google_analytics/intermediate/_int_app_store_attribution_schema.yml b/models/google_analytics/intermediate/_int_app_store_attribution_schema.yml
@@ -1,12 +1,12 @@
 version: 2
 models:
   - name: int_app_store_attribution
-    tests:
+    data_tests:
       - dbt_expectations.expect_table_row_count_to_be_between:
           min_value: 200
     columns:
       - name: shop_subdomain
-        tests:
+        data_tests:
           - unique
           - not_null
         description: The foreign key for the Shop.
diff --git a/models/google_analytics/intermediate/_int_ga_first_visits_schema.yml b/models/google_analytics/intermediate/_int_ga_first_visits_schema.yml
@@ -1,7 +1,7 @@
 version: 2
 models:
   - name: int_ga_first_visits
-    tests:
+    data_tests:
       - dbt_expectations.expect_table_row_count_to_be_between:
           min_value: 100
     description: ""
@@ -41,6 +41,6 @@ models:
         description: The locale of the first touch in the app store.
       - name: shop_subdomain
         description: The foreign key for the Shop.
-        tests:
+        data_tests:
           - not_null
           - unique
diff --git a/models/google_analytics/intermediate/int_ga_app_store_page_events.yml b/models/google_analytics/intermediate/int_ga_app_store_page_events.yml
@@ -10,7 +10,7 @@ models:
       - name: app_store_locale
       - name: app_store_detail
       - name: event_name
-        tests:
+        data_tests:
           - dbt_expectations.expect_column_distinct_count_to_be_greater_than:
               value: 0
               row_condition: event_name = 'shopify_app_install'

diff --git a/models/google_analytics/staging/_stg_anonymous_to_known_user_matching_schema.yml b/models/google_analytics/staging/_stg_anonymous_to_known_user_matching_schema.yml
@@ -3,7 +3,7 @@ version: 2
 models:
   - name: stg_anonymous_to_known_user_matching
     description: Matches Google anonymous IDs and shop_subdomains. May contain multiple rows for the same subdomain.
-    tests:
+    data_tests:
       - dbt_expectations.expect_table_row_count_to_be_between:
           min_value: 1000
 
@@ -21,5 +21,5 @@ models:
         description: The anonymouse Google Analytics user ID
       - name: SHOP_SUBDOMAIN
         description: The foreign key of the Shop.
-        tests:
+        data_tests:
           - not_null
diff --git a/models/mesa/intermediate/_int_first_workflow_keys.yml b/models/mesa/intermediate/_int_first_workflow_keys.yml
@@ -4,7 +4,7 @@ models:
     columns:
       - name: shop_subdomain
         description: The foreign key for the Shop.
-        tests:
+        data_tests:
           - unique
           - not_null
       - name: first_workflow_trigger_app

diff --git a/models/mesa/intermediate/_int_mesa_flow_events.yml b/models/mesa/intermediate/_int_mesa_flow_events.yml
@@ -3,7 +3,7 @@ models:
   - name: int_mesa_flow_events
     columns:
       - name: shop_subdomain
-        tests:
+        data_tests:
           - not_null
           - relationships:
               to: ref('int_shops')
@@ -37,7 +37,7 @@ models:
       - name: context_campaign_content
       - name: event_text
       - name: id
-        tests:
+        data_tests:
           - unique
       - name: properties_action
       - name: properties_goal
@@ -79,6 +79,7 @@ models:
       - name: category
       - name: value
       - name: key
+        description: The code-friendly key of the workflow.
       - name: workflow_id
         description: The foreign key to the originating workflow
       - name: source

diff --git a/models/mesa/intermediate/_int_mesa_shop_days.yml b/models/mesa/intermediate/_int_mesa_shop_days.yml
@@ -1,7 +1,7 @@
 version: 2
 models:
   - name: int_mesa_shop_days
-    tests:
+    data_tests:
       - dbt_expectations.expect_table_row_count_to_be_between:
           min_value: 1
           config:
@@ -12,7 +12,7 @@ models:
             - shop_subdomain
     columns:
       - name: shop_subdomain
-        tests:
+        data_tests:
           - not_null
           - relationships:
               to: ref('int_shops')
@@ -21,45 +21,45 @@ models:
                 where: mesa_plan != 'custom-app'
         description: The foreign key for the Shop.
       - name: dt
-        tests:
+        data_tests:
           - not_null
           - dbt_utils.accepted_range:
               max_value: current_date()
         description: The calendar date of the shop day.
       - name: workflow_runs_attempted_count
-        tests:
+        data_tests:
           - not_null
         description: The number of Workflow Run attempts that have been started.
       - name: workflow_runs_success_count
-        tests:
+        data_tests:
           - not_null
         description: The number of workflow runs that succeeded on this day.
       - name: workflow_success_percent
-        tests:
+        data_tests:
           - not_null
         description: The percentage of workflow runs that succeeded on this day.
       - name: billed_count
-        tests:
+        data_tests:
           - not_null
         description: "[Fill]"
       - name: daily_usage_revenue
-        tests:
+        data_tests:
           - not_null
         description: The amount of revenue from usage charges for this day.
       - name: workflow_run_success_rolling_thirty_day_count
-        tests:
+        data_tests:
           - not_null
         description: The number of successful workflow run attempts initiated in the last 30 days as of this day.
       - name: workflow_run_success_rolling_year_count
-        tests:
+        data_tests:
           - not_null
         description: The number of successful workflow run attempts initiated in the last year as of this day.
       - name: is_active
-        tests:
+        data_tests:
           - not_null
         description: Whether the shop is considered active on this day.
       - name: mesa_shop_days_id
-        tests:
+        data_tests:
           - not_null
           - unique
         description: Unique identifier for each row

diff --git a/models/mesa/intermediate/_int_mesa_shop_plan_days.yml b/models/mesa/intermediate/_int_mesa_shop_plan_days.yml
@@ -1,7 +1,7 @@
 version: 2
 models:
   - name: int_mesa_shop_plan_days
-    tests:
+    data_tests:
       - dbt_expectations.expect_compound_columns_to_be_unique:
           column_list:
             - dt

diff --git a/models/mesa/intermediate/_int_shop_calendar.yml b/models/mesa/intermediate/_int_shop_calendar.yml
@@ -1,25 +1,31 @@
 version: 2
 models:
   - name: int_shop_calendar
-    tests:
+    data_tests:
       - dbt_expectations.expect_compound_columns_to_be_unique:
           column_list:
             - dt
             - shop_subdomain
     columns:
       - name: shop_subdomain
         type: string
-        tests:
+        data_tests:
           - not_null
         description: The foreign key for the Shop.
       - name: dt
-        tests:
+        data_tests:
           - not_null
+        description: The calendar date of the shop day.
       - name: daily_plan_revenue
-        tests:
+        data_tests:
           - not_null
+        description: The amount of revenue from plan charges for this day.
       - name: MESA_PLAN
       - name: SHOPIFY_PLAN
       - name: is_shopify_zombie_plan
-        tests:
+        data_tests:
           - not_null
+        description:
+          Indicates whether the store is on a 'frozen', 'fraudulent', 'paused',
+          'dormant' or 'cancelled' Shopify plan. TRUE means they are, FALSE means they
+          are not.