Fix #295 | String Trim Trailing Zeros bool variable #296
Conversation
vasilbekk
changed the title
|
Also see #281 which provides this plus additional functionality. |
This is different as by globally setting the trim trailing zero bool value you don't need to handle the |
Absolutely! Thank you for your attention and answer, it's really pleasant. |
| // For example, if you have numeric(10,2) values stored in your database, | ||
| // and you want your API response to always be given 2 decimal places (even 2.00, 3.00, 17.00 [not 2,3,17]), | ||
| // then this variable is a great way out. | ||
| var StringTrimTrailingZeros = true |
There was a problem hiding this comment.
I think we can simply call it TrimTrailingZeros, trimming is an action widely used on strings in various languages. Or do you think it could be a bit misleading as NewFromString or RequiredFromString would not perform trimming?
There was a problem hiding this comment.
I also wonder whether we should introduce another config var for specifying NewFromString behaviour. The current implementation does not trim zeroes during the initialization from string, but we saw in the past that some developers would like to see such an option.
Unfortunately, we cannot use this newly introduced variable for both of these cases as we would break backward compatibility.
| @@ -3339,3 +3339,48 @@ func ExampleNewFromFloat() { | |||
| //0.123123123123123 | |||
| //-10000000000000 | |||
| } | |||
|
|
|||
| func TestDecimal_String(t *testing.T) { | |||
There was a problem hiding this comment.
Could we separate test cases for TrimTrailingZeros=true and TrimTrailingZeros=false? Thanks to that we could easily catch potential bugs and it would improve overall code maintainability.
| // StringTrimTrailingZeros should be set to false if you want the decimal stringify without zeros trailing. | ||
| // By default, when decimal is output as a string (for example, in JSON), zeros are truncated from it (2.00 -> 2, 3.11 -> 3.11, 13.000 -> 13). | ||
| // But this logic can be changed by this variable. | ||
| // For example, if you have numeric(10,2) values stored in your database, | ||
| // and you want your API response to always be given 2 decimal places (even 2.00, 3.00, 17.00 [not 2,3,17]), | ||
| // then this variable is a great way out. |
There was a problem hiding this comment.
| // StringTrimTrailingZeros should be set to false if you want the decimal stringify without zeros trailing. | |
| // By default, when decimal is output as a string (for example, in JSON), zeros are truncated from it (2.00 -> 2, 3.11 -> 3.11, 13.000 -> 13). | |
| // But this logic can be changed by this variable. | |
| // For example, if you have numeric(10,2) values stored in your database, | |
| // and you want your API response to always be given 2 decimal places (even 2.00, 3.00, 17.00 [not 2,3,17]), | |
| // then this variable is a great way out. | |
| // TrimTrailingZeros specifies whether trailing zeroes should be trimmed from a string representation of decimal. | |
| // If set to true, trailing zeroes will be truncated (2.00 -> 2, 3.11 -> 3.11, 13.000 -> 13), | |
| // otherwise trailing zeroes will be preserved (2.00 -> 2.00, 3.11 -> 3.11, 13.000 -> 13.000). | |
| // Setting this value to false can be useful for APIs where exact decimal string representation matters. |
There was a problem hiding this comment.
What do you think about it? A bit simplified and a bit more explicit version of your suggestion.
|
Hope this PR will be completed soon. |
Fix #295