Increase default precision #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve 18 decimal places Signed-off-by: Elias Van Ootegem <[email protected]>
…assets like ETH Signed-off-by: Elias Van Ootegem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the
PowPrecisionNegativeExponentvariable in version 1.4 changes the behaviour ofPowsignificantly. In my use-case, I rely onPowto convert amounts to and from a human-readable format and the same amount in the asset precision. When dealing with crypto (e.g. ETH), 18 decimal places is the de-facto norm.Having this package default to a seemingly arbitrary precision of 16, especially for negative exponents makes little sense, defaults of 18 means this package can be used without having to rely on messy things like changing global variables to tweak the behaviour in an
initfunction