Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file watcher for shopware/shopware #1209

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Add file watcher for shopware/shopware #1209

merged 10 commits into from
Dec 8, 2023

Conversation

Isengo1989
Copy link
Collaborator

Add a JSON in a comment, read the data and check the file MD5 sum

@Isengo1989 Isengo1989 changed the title First throw Add file watcher for shopware/shopware Nov 30, 2023
@Isengo1989 Isengo1989 force-pushed the poc/watch-files branch 4 times, most recently from 656547d to 0dc4a91 Compare December 6, 2023 16:05
bojanrajh
bojanrajh approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@bojanrajh bojanrajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer storing comments in a single file, mainly because of the code copy/paste feature. But hey, it's a PoC, so let's go with it. :)

@Isengo1989 Isengo1989 merged commit a9f8e64 into main Dec 8, 2023
7 of 8 checks passed
@Isengo1989 Isengo1989 deleted the poc/watch-files branch December 8, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojanrajh bojanrajh bojanrajh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isengo1989 @bojanrajh