Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder name to underscore #1466

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

SirPhoeniix
Copy link
Contributor

@SirPhoeniix SirPhoeniix commented Sep 2, 2024

I have noticed that the documentation says that the folder for your translations should be de-DE or en-GB. I have updated this in this pull request because I had to name the folders de_DE and en_GB to get translations working.

@bojanrajh
Copy link
Collaborator

@shyim This was changed in this PR. Did something really change in core?

@Isengo1989
Copy link
Collaborator

@SirPhoeniix can you please provide the version you have tested / used this on ?

@shyim
Copy link
Member

shyim commented Sep 5, 2024

@tobiasberge do you maybe know?

@tobiasberge
Copy link
Contributor

@shyim Looks correct to me, in the core underscore is also used.

@bojanrajh bojanrajh merged commit f882a29 into shopware:main Sep 5, 2024
4 of 6 checks passed
@SirPhoeniix
Copy link
Contributor Author

@SirPhoeniix can you please provide the version you have tested / used this on ?

I am using version 6.6.5.1, but it looks like the PR was already merged :)

@Ideosynkrat
Copy link

The tutorial page still claims the folder structure should be
└── SwagBasicExample
└── src
├─ Resources
│ └─ snippet
│ ├─ de_DE
│ │ └─ example.de-DE.json
│ └─ en_GB
│ └─ example.en-GB.json
└─ SwagBasicExample.php
At least in 6.6.7.1 the folder has to be named with a '-'. Also that would be an opportunity to clarify which locale notation is used. Underscore seems to follow the ICU definition while the dash notation seems to be used by ISO.

@mitelg
Copy link
Member

mitelg commented Nov 5, 2024

hey @Ideosynkrat
it seems that the directory structure does not matter at all 😬

I will investigate further on this and will update the article accordingly then

@mitelg
Copy link
Member

mitelg commented Nov 5, 2024

FYI: #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants