Skip to content

Commit

Permalink
NEXT-33446 - move job to check for circular dependencies to root
Browse files Browse the repository at this point in the history
  • Loading branch information
Haberkamp committed Feb 8, 2024
1 parent 6dd4e91 commit 37d1976
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 21 deletions.
25 changes: 25 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,28 @@ jobs:

- name: unit
run: pnpm run test:unit

circular-dependencies:
name: Check for circular dependencies (Madge)
runs-on: ubuntu-latest
env:
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
TURBO_TEAM: ${{ secrets.TURBO_TEAM }}
steps:
- name: Checkout
uses: actions/checkout@v2

- uses: pnpm/action-setup@v2
with:
version: 8

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Install dependencies
run: pnpm install

- name: madge
run: pnpm --filter @shopware-ag/meteor-admin-sdk run circular-dependencies
21 changes: 0 additions & 21 deletions packages/admin-sdk/.github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,6 @@ name: Tests
on: push

jobs:
circular-dependencies:
name: Circular dependencies (Madge)
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '18'
- name: Retrieve the cached "node_modules" directory (if present)
uses: actions/cache@v2
id: node-cache
with:
path: node_modules
key: node-modules-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies (if the cached directory was not found)
if: steps.node-cache.outputs.cache-hit != 'true'
run: npm ci
- name: madge
run: npm run circular-dependencies
playwright-run:
name: Playwright Integration Tests
timeout-minutes: 20
Expand Down

0 comments on commit 37d1976

Please sign in to comment.