remove default margin from base field #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Haberkamp
force-pushed
the
remove-default-margin-from-base-field
branch
2 times, most recently
from
395cea7
to
82a8128
Compare
Haberkamp
force-pushed
the
remove-default-margin-from-base-field
branch
from
82a8128
to
bea59e6
Compare
alastair-simon
approved these changes
Sep 25, 2024
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR remove the default margin for the base field and therefore for many of the form elements.
Why?
The parent component should always take care of spacing elements, not the element itself.
How?
The default margin gets removed when the
removeDefaultMarginfuture flag is enabled.Testing?
The visual tests should catch every issue, but feel free to test it out yourself using the branch preview below.
Anything Else?