Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move toast over to plain css #317

Merged
merged 2 commits into from
Sep 27, 2024
Merged

move toast over to plain css #317

merged 2 commits into from
Sep 27, 2024

Conversation

Haberkamp
Copy link
Contributor

What?

This PR removes the SCSS of the mt-toast notification and replaces it with plain css.

Why?

This brings us a step closer to getting rid of plain css.

How?

Replaced the SCSS with plain CSS.

Testing?

The visual tests will catch issues if something looks different from how it's supposed to look like.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:14am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:14am

Copy link

pkg-pr-new bot commented Sep 26, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@317
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@317
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@317
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@317

commit: 56cf9ad

@Haberkamp Haberkamp enabled auto-merge (rebase) September 27, 2024 07:12
@Haberkamp Haberkamp merged commit cd251b1 into main Sep 27, 2024
8 checks passed
@Haberkamp Haberkamp deleted the move-toast-over-to-plain-css branch September 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants