fix: add focus style to checkbox #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
fabianhueske
approved these changes
Oct 15, 2024
commit: |
Haberkamp
force-pushed
the
add-focus-style-to-checkbox
branch
from
44b1e1e
to
bf9d571
Compare
fabianhueske
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a focus ring to the checkbox component when the user focuses the checkbox.
Why?
This change improves the accessibility for this component.
How?
I've added a focus ring to the checkbox.
Testing?
The interaction tests should be aware of this new change, but feel free to test it yourself. Checkout the branch preview below to do that.