Replace flatpickr #344
Open
Replace flatpickr #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Haberkamp
force-pushed
the
replace-flatpickr
branch
from
6f6aa4a
to
7d982fb
Compare
Haberkamp
requested changes
Oct 30, 2024
| @@ -35,6 +35,7 @@ | |||
| "@storybook/addon-a11y": "^8.1.1", | |||
| "@testing-library/jest-dom": "^6.4.6", | |||
| "@testing-library/vue": "^8.1.0", | |||
| "@vuepic/vue-datepicker": "^9.0.3", | |||
There was a problem hiding this comment.
The flackpickr dependency can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Flatpickr replaced by vue 3 datepicker
Why?
Needed to be updated to fit design system more closely
How?
Repalced flatpickr with vue 3 datepicker and updated styling
Testing?
I've written some unit tests but feel free to take a look yourself