Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mt data table filter to custom i18n #355

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

Haberkamp
Copy link
Contributor

@Haberkamp Haberkamp commented Oct 30, 2024

What?

This PR migrates the components over to the custom built useI18n hook.

Why?

This brings us a step closer to getting rid of the vue-i18n dependency.

How?

I migrated the translations to the new custom built useI18n hook.

Testing?

The visual tests should catch issues.

Anything Else?

  • I migrated the component over to the composition api
  • I migrated the component over to plain css

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 9:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:52am

Copy link

pkg-pr-new bot commented Nov 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@355
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@355
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@355
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@355

commit: 0963532

@Haberkamp Haberkamp merged commit 0280b80 into main Nov 4, 2024
15 checks passed
@Haberkamp Haberkamp deleted the migrate-mt-data-table-filter-to-custom-i18n branch November 4, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants