Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mt-inheritance-switch to custom i18n #361

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

Haberkamp
Copy link
Contributor

What?

I've migrated the component over to the composition api and the new usei18n composable.

Why?

The vue-18n package makes setting up the component library much harder. This custom built one makes it easier.

How?

I've migrated the component from the vue-i18n package to the custom built useI18n composable.

Testing?

Feel free to test it yourself.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 1:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 1:23pm

Copy link

pkg-pr-new bot commented Nov 5, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@361
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@361
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@361
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@361

commit: dca5b1d

@Haberkamp Haberkamp merged commit 78d2009 into main Nov 6, 2024
19 checks passed
@Haberkamp Haberkamp deleted the migrate-mt-inheritance-switch-to-custom-i18n branch November 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants