Rework tabs #426
Open
Rework tabs #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g it multiple times
…yPlusNav composable
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jleifeld
reviewed
Dec 11, 2024
packages/component-library/src/components/overlay/mt-bare-popover/mt-bare-popover.vue
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR re-works the
mt-tabscomponent.Why?
The current implementation had a bunch of a11y issues. And still relied on the options API.
How?
I've re-written the tab component from scratch.
Testing?
I've written a handful of unit tests to make sure the component works as expected.
Anything Else?
Can only be merged after the popover component has been updated.