fix: Change tooltip file to scss format #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenquocdaile
requested review from
jleifeld,
Haberkamp,
seggewiss and
alastair-simon
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Haberkamp can you have a look here. I remember you wanted to go away from SCSS. If this is the case we should fix the issue directly in the Vite config or the import |
|
@nguyenquocdaile I do not experience the issue. The tooltip.css files does not contain any SCSS. Could you try pulling from main again and see if the issue still persists? |
@Haberkamp looks weird, I don't know why it happened with me :D Screen.Recording.2025-01-08.at.17.11.19.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If we run
pnpm run storybookin component-library. It will have an error.It requires a
sassfile, so I changedtooltip.cssto atooltip.scssfile.It seems that an SCSS file is required in the vite configuration here.
https://github.com/shopware/meteor/blob/main/packages/component-library/vite.config.ts#L31