Fix stylelint font rule #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Haberkamp
previously approved these changes
Jan 8, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-tokens
commit: |
alastair-simon
force-pushed
the
fix-stylelint-fonttoken
branch
from
812d50a to
2f51e9a
Compare
Lucsy3012
approved these changes
Jan 14, 2025
Haberkamp
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adjustments to the stylelint font rule to exclude font-feature-settings
Why?
Currently the css property font-feature-setting throws an error but it should be excluded
How?
By making the rule more specific to not include all font properties
Testing?
I have added some tests to make sure the adjustment is working