Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylelint border rule #443

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

alastair-simon
Copy link
Contributor

What?

Adjustments to the stylelint border rule to allow expressions

Why?

Currently the css property border-radius cannot accept expressions and throws a linting error

How?

Adding expression to acceptable values for border radius

Testing?

I have added some tests to make sure the adjustment is working

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:36pm
meteor-component-library ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:36pm

@alastair-simon alastair-simon force-pushed the fix-stylelint-border-rule branch from a18bc04 to bf5e384 Compare January 3, 2025 16:36
Copy link
Contributor

@Haberkamp Haberkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one thing you can change the rest looks good.

@@ -0,0 +1,5 @@
---
"@shopware-ag/stylelint-plugin-meteor": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes are always patch updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants