fix(component-library): prevent user from changing value of number field with linked inheritance #484
+80
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I fixed a bug were users were able to edit the value of a number field with a linked inheritance.
Why?
User should not be able to edit input fields with linked inheritance. To do so they must first unlink the inheritance.
How?
I disabled the input field and the buttons to increment and decrement the value.
Testing?
I wrote a couple of tests to make sure the bug is fixed.
To manually test it, check out the branch preview and set
isInherited
andisInheritanceField
to true.Now try changing the value, it won't be possible, which is the correct behavior.
Anything else
I also added some visual tests to make sure the number field with linked inheritance looks like it should