Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run visual tests when creating pull request #67

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Haberkamp
Copy link
Contributor

What?

I enabled the visual tests job for every pull request.

Why?

We did this to reduce the amount of visual bugs that get into the main branch.

How?

By running the visual tests job when creating a pull request.

Testing?

The pipeline should turn green on it's own.

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 8:55am
meteor-component-library ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 8:55am

@Haberkamp Haberkamp merged commit aeeb810 into main Mar 4, 2024
6 of 8 checks passed
@Haberkamp Haberkamp deleted the run-visual-test-when-creating-pull-request branch March 4, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants