implement tokens for sw-card component #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Haberkamp
force-pushed
the
implement-tokens-for-card-component
branch
2 times, most recently
from
ed89308
to
bc2bca1
Compare
fabianhueske
reviewed
Mar 4, 2024
packages/component-library/src/components/layout/sw-card/sw-card.vue
Outdated
Show resolved
Hide resolved
fabianhueske
reviewed
Mar 4, 2024
packages/component-library/src/components/layout/sw-card/sw-card.vue
Outdated
Show resolved
Hide resolved
Haberkamp
force-pushed
the
implement-tokens-for-card-component
branch
from
22aa2b7
to
71a6479
Compare
Haberkamp
force-pushed
the
implement-tokens-for-card-component
branch
from
71a6479
to
437caef
Compare
fabianhueske
approved these changes
Mar 4, 2024
jleifeld
approved these changes
Mar 4, 2024
packages/component-library/src/components/layout/sw-card/sw-card.stories.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added design tokens to the
sw-cardcomponent.Why?
This makes the component support multiple themes.
How?
I replaced the SCSS variables with CSS custom properties that use our Meteor Tokens.
Testing?
You can use the preview branch to check the results