Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for this **EXPERIMENTAL** branch #93

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kporangehat
Copy link

Not for merging. just for review.

Adds ShotgunMulti object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib.
Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info.
More to come.

Adds `ShotgunMulti` object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib.
Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info.
More to come.
@manneohrstrom
Copy link
Contributor

This is exciting! @sgsteph should watch this space :)

@sgsteph
Copy link
Contributor

sgsteph commented Nov 6, 2015

I definetely do ;)

Stéphane Deverly

Le 5 nov. 2015 à 22:21, Manne Öhrström [email protected] a écrit :

This is exciting! @sgsteph should watch this space :)


Reply to this email directly or view it on GitHub.

@kporangehat
Copy link
Author

heh... lots of this is about to change :). Moving away from the subclassing and going to make this much more independent. Updates coming hopefully very soon!

@cmihaly
Copy link

cmihaly commented Nov 6, 2015

Very exciting to see these changes! Chris

Sent from my iPad

On Nov 5, 2015, at 10:25 PM, KP [email protected] wrote:

heh... lots of this is about to change :). Moving away from the subclassing and going to make this much more independent. Updates coming hopefully very soon!


Reply to this email directly or view it on GitHub.

@sgsteph
Copy link
Contributor

sgsteph commented Nov 6, 2015

A quick heads up that I had issues with requests.get and https://sg-media-usor-01.s3.amazonaws.com urls and ended up having verify=False for my download requests. By default, verify is True I think.

@kporangehat
Copy link
Author

@sgsteph interesting. I did not run into any issues on my end. Were the issues simply verification failures or something else?

@monkeydev
Copy link

The error was :
Error reported: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
I didn’t have the issue on my laptop but on remote servers where I deployed a service.

On 06 Nov 2015, at 18:18, KP [email protected] wrote:

@sgsteph https://github.com/sgsteph interesting. I did not run into any issues on my end. Were the issues simply verification failures or something else?


Reply to this email directly or view it on GitHub #93 (comment).

@carlos-villavicencio-adsk carlos-villavicencio-adsk marked this pull request as draft January 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants