swap to regex-lite #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
swap-to-regex-lite
branch
from
183e6f9
to
bca6f29
Compare
rukai
force-pushed
the
swap-to-regex-lite
branch
from
bca6f29
to
4ea286b
Compare
conorbros
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex-lite is by the same author as the regex crate.
https://github.com/rust-lang/regex/tree/master/regex-lite#motivation
It compiles in 0.73s instead of 1.93s and takes up 94KB in the compiled binary instead of 565KB
Reference https://github.com/rust-lang/regex/tree/master/regex-lite#motivation
This does come with some cost to regex performance, however, this library uses regex solely while waiting for a docker instance to come up, as such a slower regex wont slow us down as we are already waiting around.