Skip to content

Commit

Permalink
Fixed x64 plugin incompatibility issue with the NPP v8.3 release.
Browse files Browse the repository at this point in the history
  • Loading branch information
shriprem committed Feb 4, 2022
1 parent 409a757 commit e9c668d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

![GitHub](https://img.shields.io/github/license/shriprem/FWDataViz) ![GitHub release (latest by date)](https://img.shields.io/github/v/release/shriprem/FWDataViz) ![GitHub all releases](https://img.shields.io/github/downloads/shriprem/FWDataViz/total)
#### Fixed Width Data Visualizer plugin for Notepad++
[Current Version: 2.4.0.1](https://github.com/shriprem/FWDataViz/blob/master/VersionHistory.md)
[Current Version: 2.4.0.2](https://github.com/shriprem/FWDataViz/blob/master/VersionHistory.md)

![FWDataViz](https://raw.githubusercontent.com/shriprem/FWDataViz/master/images/multi_rec_weather_stations.png)

Expand Down
9 changes: 9 additions & 0 deletions VersionHistory.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Version History

### Version 2.4.0.2
**Background:** With its v8.3 release, the Notepad++ *x64* binary will support opening 2GB+ files. However, this change causes compability issue with many *x64* plugins, [and they will need to be recompiled with a modified C++ header file](https://community.notepad-plus-plus.org/topic/22471/recompile-your-x64-plugins-with-new-header).

The _FWDataViz_ ***x64*** plugin was affected by this incompatibility issue specifically when trying to extract data in the [Data Extraction dialog](https://github.com/shriprem/FWDataViz/blob/master/docs/data_extract_dialog.md). With the suggested recompile of the _FWDataViz_ plugin with the modified C++ header file, the v2.4.0.2 release fixes this issue.

**Release:** [2.4.0.2 Release](https://github.com/shriprem/FWDataViz/releases/tag/v2.4.0.2)

---

### Version 2.4.0.1
1. Updated `NPP_Plugin_Darkmode.dll` to [version 1.1.0.0](https://github.com/shriprem/NPP_Plugin_Darkmode/releases/tag/v1.1.0.0). This fixes darkmode rendering issue in Windows 11.

Expand Down
10 changes: 5 additions & 5 deletions src/NPP/Sci_Position.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
** Define the Sci_Position type used in Scintilla's external interfaces.
** These need to be available to clients written in C so are not in a C++ namespace.
**/
// Copyright 2015 by Neil Hodgson <[email protected]>
// The License.txt file describes the conditions under which this software may be distributed.
// Copyright 2015 by Neil Hodgson <[email protected]>
// The License.txt file describes the conditions under which this software may be distributed.

#ifndef SCI_POSITION_H
#define SCI_POSITION_H
Expand All @@ -18,12 +18,12 @@ typedef ptrdiff_t Sci_Position;
typedef size_t Sci_PositionU;

// For Sci_CharacterRange which is defined as long to be compatible with Win32 CHARRANGE
typedef long Sci_PositionCR;
typedef intptr_t Sci_PositionCR;

#ifdef _WIN32
#define SCI_METHOD __stdcall
#define SCI_METHOD __stdcall
#else
#define SCI_METHOD
#define SCI_METHOD
#endif

#endif
4 changes: 2 additions & 2 deletions src/Resources/VisualizerPlugin.rc
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

#include <windows.h>

#define VERSION_VALUE "2.4.0.1"
#define VERSION_DIGITALVALUE 2,4,0,1
#define VERSION_VALUE "2.4.0.2"
#define VERSION_DIGITALVALUE 2,4,0,2

VS_VERSION_INFO VERSIONINFO
FILEVERSION VERSION_DIGITALVALUE
Expand Down

0 comments on commit e9c668d

Please sign in to comment.